Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Design "hide sites if" options on Advanced Options Dialog #6201

Closed
luixxiul opened this issue Dec 14, 2016 · 2 comments · Fixed by #6047
Closed

Design "hide sites if" options on Advanced Options Dialog #6201

luixxiul opened this issue Dec 14, 2016 · 2 comments · Fixed by #6047
Assignees
@luixxiul
Labels
design A design change, especially one which needs input from the design team. feature/rewards QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.13.0

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Dec 14, 2016 •
edited
Loading

This is a follow-up of #4681

courtesy of @bradleyrichter
image

I'm creating like this (the select element styling is based on #6084):
screenshot 2016-12-12 0 19 53

  • Platform (Win7, 8, 10? macOS? Linux distro?):

  • Brave Version: master branch

  • Any related issues:
@luixxiul luixxiul added the design A design change, especially one which needs input from the design team. label Dec 14, 2016
@luixxiul luixxiul self-assigned this Dec 14, 2016
@bradleyrichter
Copy link
Contributor

looks good!

@luixxiul luixxiul mentioned this issue Dec 15, 2016
Merged
4 tasks
@luixxiul luixxiul added this to the 0.13.0 milestone Dec 15, 2016
This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Dec 20, 2016
Closed
@luixxiul
Copy link
Contributor Author

Test plan: same as #6221 (comment)

@alexwykoff alexwykoff mentioned this issue Jan 17, 2017
Closed
This was referenced Jan 18, 2017
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
design A design change, especially one which needs input from the design team. feature/rewards QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

Refactor about:preferences#payments followups
4 participants
@alexwykoff @luixxiul @bradleyrichter @srirambv