Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Don't prompt for restart when clearing cookies / history / images and files #6611

Closed
bsclifton opened this issue Jan 11, 2017 · 1 comment
Closed

Don't prompt for restart when clearing cookies / history / images and files #6611

bsclifton opened this issue Jan 11, 2017 · 1 comment
Labels
feature/cookies post-v1 We don't expect to be able to resolve this before releasing v1.0 with Brave Core (instead of Muon). priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). privacy stale

Comments

@bsclifton
Copy link
Member

Starting with #4157, a restart is required when choosing to clear cookies / history / images and files

User @Kanichiro recently brought this up with #4082 (comment).

Is there anything we can do to improve the experience?

  • is it possible to fix without restarting?
  • if not (or fix isn't easy), can we check if any WebRTC device IDs exist? if not, then don't prompt

cc: @diracdeltas @bbondy @bradleyrichter
@bsclifton bsclifton mentioned this issue Jan 11, 2017
Closed
@diracdeltas
Copy link
Member

It seemed like a lot of work to reset the WebRTC deviceId in muon without restarting, but someone should look into it again. IIRC the webrtc device ID always exists since it is set when the session is created.

This is a good starting point - https://chromium.googlesource.com/chromium/src/+/4db1329e005388540eb07429ac97827ca9bc422b.

@bsclifton bsclifton added this to the 1.1.0 milestone Jan 12, 2017
@alexwykoff alexwykoff modified the milestones: 1.1.0, Backlog Nov 1, 2017
@tildelowengrimm tildelowengrimm added post-v1 We don't expect to be able to resolve this before releasing v1.0 with Brave Core (instead of Muon). priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). labels Apr 3, 2018
@bsclifton bsclifton added the stale label Sep 3, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature/cookies post-v1 We don't expect to be able to resolve this before releasing v1.0 with Brave Core (instead of Muon). priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). privacy stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@diracdeltas @tildelowengrimm @alexwykoff @bsclifton