Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

New Tab context menu is retained even after clicking one new tab button #6700

Closed
srirambv opened this issue Jan 17, 2017 · 3 comments
Closed

Comments

@srirambv
Copy link
Collaborator

srirambv commented Jan 17, 2017

QA Steps:
1. Right click/long press on new tab button to show the context menu
2. Click on the new tab icon, the context menu should be closed
3. Right click/long press on new tab button to show the context menu
4. Click on other existing tab or anywhere else in the browser, context menu should be closed


Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
New Tab context menu is retained even after clicking one new tab button

Expected behavior:
Context menu should get closed if the new tab button is clicked

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.13.0
    rev 105a1a7
    Existing behavior since 0.12.10

  • Steps to reproduce:

    1. Right click/long press on new tab button to show the context menu
    2. Click on the new tab icon, the context menu is retained and not dismissed
    3. Right click/long press on new tab button to show the context menu
    4. Click on other existing tab or anywhere else in the browser, context menu is closed
  • Screenshot if needed:
    newtabcontext

  • Any related issues:
    Please change milestone if required

@srirambv
Copy link
Collaborator Author

Same with hamburger menu as well. When hamburger menu is clicked and then clicked on the tabs bar the menu is not closed. Only if clicked outside tabs bar then the menu closes

@bbondy bbondy removed this from the 0.13.2 milestone Jan 22, 2017
@cndouglas
Copy link

I think this was fixed with #7748 (native context menu).

@bsclifton
Copy link
Member

@liunkae yes- you are correct 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.