Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add support for LessPass (stateless open source password manager) #7846

Closed
edouard-lopez opened this issue Mar 22, 2017 · 15 comments
Closed
Labels
feature/extensions feature/password-manager fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. suggestion wontfix

Comments

@edouard-lopez
Copy link
Contributor

edouard-lopez commented Mar 22, 2017

LessPass focus on privacy and manage your passwords directly from your browser, they never leave your device and passwords are never stored. We use a site, a login and a master password to generate a unique password. So no need to sync your password vault across every device. Learn more.

All our supported platform are build around a core NPM module with a clean api used to create passwords that should be easy to port to Brave (as we already support Android, Chrome and Firefox, Cozy Cloud, Linux distros, Terminal).

Screenshot

In current supported browser, we integrate as a pop-up extension.
demo-2 3 x

Related issues

@edouard-lopez
Copy link
Contributor Author

edouard-lopez commented Mar 23, 2017

I managed to run the extension in brave following Developer-Notes-on-Installing-or-Updating-Extensions.

Not sure what's the next step. Could give us some pointers to better integrate with Brave?

Install

sudo apt-get install libgnome-keyring-dev
git clone --depth 1 [email protected]:brave/browser-laptop.git
cd browser-laptop
yarn install    

Add extension

Copy it from Chromium extensions' directory:

$HOME/.config/chromium/Profile 1/Extensions/lcmbpoclaodbgkbjafnkbbinogcbnjih

to Brave extensions' directory:

browser-laptop/app/extensions/

Load the extension

Edit browser-laptop/app/extension.js to add the following lines:

// lesspass
config.myExtensionId = 'lcmbpoclaodbgkbjafnkbbinogcbnjih';
config.myExtensionPathToManifest = 'lcmbpoclaodbgkbjafnkbbinogcbnjih/2.3.5_0';
extensionInfo.setState(config.myExtensionId, extensionStates.REGISTERED)
loadExtension(config.myExtensionId, getExtensionsPath(config.myExtensionPathToManifest))

Run

On one terminal

yarn watch

On a second terminal

yarn install

Demo time 🎉

brave lesspass-extension

Known issue

  • shortcut Ctrl+Shift+L is not working.

@bsclifton
Copy link
Member

cc: @jonathansampson

@edouard-lopez
Copy link
Contributor Author

Should I submit a pull with my modification of extensions.js? It seems a bit rough as the extension will always be shown in the toolbar.
Where is the doc if I want to integrate in the same way as 1Password/Dashlane/LastPass?

@bsclifton
Copy link
Member

@edouard-lopez there isn't a doc showing how to integrate like 1Password/Dashlane/LastPass... yet

I created a stub here which I'll be updating here over the next few minutes 😄
https://github.com/brave/browser-laptop/wiki/Password-manager-support

@bsclifton
Copy link
Member

@edouard-lopez I just finished updating the doc above; please let me know if the information is useful 😄 There should be enough info there for you to generate PRs against the 3 repos we have

@edouard-lopez
Copy link
Contributor Author

Thanks @bsclifton, after some discussion we are limiting our project's scope to focus on some feature.
I'm closing this, as the extension is functional, we will wait for Brave to enable web extension.

@edouard-lopez
Copy link
Contributor Author

edouard-lopez commented May 10, 2017

Extension preferences has landed, hopefully it will be possible to install LessPass extension soon.

Related:

@jonathansampson
Copy link
Collaborator

jonathansampson commented May 10, 2017

@edouard-lopez Thank you for the update! We're making great progress towards broader/more-rapid adoption. Stay tuned.

@luixxiul luixxiul reopened this May 11, 2017
@eljuno
Copy link
Contributor

eljuno commented Aug 26, 2017

@jonathansampson
Copy link
Collaborator

@edouard-lopez When you tested this, were all primary user-scenarios covered, or did you run into issues (other than the broken keyboard command) that weren't working entirely?

I'd love to see LessPass move forward :)

@edouard-lopez
Copy link
Contributor Author

edouard-lopez commented Sep 28, 2017

@jonathansampson
Yep, everything was working fine. Do we need to package the app in some ways our will you support the chrome format?

@jonathansampson
Copy link
Collaborator

jonathansampson commented Oct 27, 2017

@edouard-lopez This is great to hear. I'll speak with some of the team about adding support for LessPass! The Chrome format (CRX) is all we need.

@edouard-lopez
Copy link
Contributor Author

Thanks @jonathansampson this will help speed up process and streamline update of the extension.

If you need information feel free to ping me or guillaume on twitter or submit issue.

@cezaraugusto cezaraugusto added this to the Triage Backlog milestone Nov 8, 2017
@edouard-lopez
Copy link
Contributor Author

Can I be of some help to push this forward?

@bsclifton bsclifton removed this from the Triage Backlog milestone Aug 23, 2018
@bsclifton
Copy link
Member

This is something we won't be able to get to- closing as wontfix

However, with brave-core, potentially anything in the Chrome Web Store would be available (so this is resolved with brave-core)

@bsclifton bsclifton added wontfix fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. labels Aug 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/extensions feature/password-manager fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. suggestion wontfix
Projects
None yet
Development

No branches or pull requests

6 participants