Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactor bookmarksToolbar.js with Aphrodite #7920

Closed
luixxiul opened this issue Mar 27, 2017 · 0 comments
Closed

Refactor bookmarksToolbar.js with Aphrodite #7920

luixxiul opened this issue Mar 27, 2017 · 0 comments
Assignees
@luixxiul
Labels
feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite refactoring release-notes/include
Milestone
0.15.0

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Mar 27, 2017 •
edited by bsclifton
Loading

Test Plan

  1. Automated test should be passing (CXX=g++-4.8 NODE_ENV=test TEST_DIR=bookmark-components)
  2. Bookmark several pages if you have not
  3. Test that creating a bookmark on the bookmarks toolbar works
  4. Test that creating a bookmark folder on the bookmarks toolbar works
  5. Test that moving a bookmark into a folder by drag and drop on the bookmarks folder works
  6. Test that clicking a bookmark in the toolbar loads the bookmark.
  7. Test that clicking a bookmark in a bookmark toolbar folder loads the bookmark.
  8. Change the window size
  9. Make sure the overflow indicator is displayed on the right of the bookmarks toolbar

Describe the issue you encountered: Refactor bookmarksToolbar.js with Aphrodite.

1st attempt: https://github.com/luixxiul/browser-laptop/commit/abbd11c3715192617e981493943483a3de28e95f

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:
@luixxiul luixxiul added this to the 0.14.1 milestone Mar 27, 2017
@luixxiul luixxiul self-assigned this Mar 27, 2017
@luixxiul luixxiul mentioned this issue Mar 27, 2017
Merged
4 tasks
@alexwykoff alexwykoff mentioned this issue Mar 31, 2017
Closed
82 tasks
This was referenced Apr 9, 2017
Closed
Closed
Closed
Closed
This was referenced Apr 13, 2017
Closed
Closed
Closed
This was referenced Apr 21, 2017
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Apr 25, 2017
Closed
@alexwykoff alexwykoff changed the title Refactor bookmarksToolbar.js with Aphrodite Updated style for bookmarks toolbar Apr 25, 2017
@luixxiul luixxiul changed the title Updated style for bookmarks toolbar Updated style for bookmarks toolbar - refactor bookmarksToolbar.js with Aphrodite Apr 25, 2017
@luixxiul luixxiul changed the title Updated style for bookmarks toolbar - refactor bookmarksToolbar.js with Aphrodite Refactor bookmarksToolbar.js with Aphrodite Sep 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite refactoring release-notes/include
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
5 participants
@alexwykoff @luixxiul @cezaraugusto @bsclifton @srirambv