Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Badge designs are inconsistent #8185

Closed
jonathansampson opened this issue Apr 10, 2017 · 1 comment
Closed

Badge designs are inconsistent #8185

jonathansampson opened this issue Apr 10, 2017 · 1 comment
Assignees
@jonathansampson
Labels
design A design change, especially one which needs input from the design team. feature/extensions feature/titlebar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.15.0

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented Apr 10, 2017 •
edited by luixxiul
Loading

Test plan

#8191 (comment)

  1. Set LastPass as your active password manager in Preferences > Security
  2. Add a login/password for GitHub
  3. Go to https://github.com/login and the LastPass icon with badge should show in the top right corner
  4. Confirm it matches this new spec (consistent with Lion):
    image

Original issue description

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Badge designs are not consistent. Proposed solution is to adopt the Lion badge style for extensions.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Desktop

  • Screenshot if needed:

image
@jonathansampson jonathansampson added design A design change, especially one which needs input from the design team. feature/extensions feature/titlebar labels Apr 10, 2017
@jonathansampson jonathansampson self-assigned this Apr 10, 2017
@jonathansampson jonathansampson mentioned this issue Apr 10, 2017
Merged
4 tasks
@bsclifton
Copy link
Member

marked as release-notes/exclude since the badge was added with this release (wasn't in prior releases)

@luixxiul luixxiul added this to the 0.14.2 milestone Apr 10, 2017
This was referenced Apr 13, 2017
Closed
Closed
Closed
Closed
This was referenced Apr 21, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonathansampson jonathansampson

Labels
design A design change, especially one which needs input from the design team. feature/extensions feature/titlebar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
6 participants
@jonathansampson @alexwykoff @luixxiul @cezaraugusto @bsclifton @srirambv