Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

imdb.com video player only loads with blocking disabled #8521

Closed
6 tasks
lukemulks opened this issue Apr 27, 2017 · 1 comment
Closed
6 tasks

imdb.com video player only loads with blocking disabled #8521

lukemulks opened this issue Apr 27, 2017 · 1 comment

Comments

@lukemulks
Copy link
Collaborator

lukemulks commented Apr 27, 2017

@darkdh reported that imdb.com was not loading the video player:

image

  • I've been able to repro on win10.

  • imdb appears to be loading the video player, only if the ad call is allowed to be made.

  • Blocking ads prevents the player from loading.

  • Disabling blocking allows for the player load as expected.

  • Confirm that this code is blocking the player:

doWithAds(function(){
if ('injected_slot' == 'injected_slot') {
ad_utils.inject_ad.register('injected_billboard');
} else {
ad_utils.gpt.render_ad('injected_billboard');
}
}, "ad_utils not defined, unable to render client-side GPT ad or injected ad.");
  • Locate corresponding ad call in network traffic.
  • Find appropriate exception
  • Apply Solution
  • Confirm fix
  • Close issue
@srirambv
Copy link
Collaborator

Closing in favour of brave/brave-browser#902

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants