Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Rename 'general.blocked-count-badge' to 'shields.blocked-count-badge' #8949

Closed
luixxiul opened this issue May 19, 2017 · 0 comments
Closed

Rename 'general.blocked-count-badge' to 'shields.blocked-count-badge' #8949

luixxiul opened this issue May 19, 2017 · 0 comments
Assignees
@luixxiul
Labels
feature/shields polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.17.13 (Release ...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented May 19, 2017 •
edited
Loading

Test plan

  1. Open js/constants/appConfig.js and see they were renamed
  2. Open about:preferences#shields
  3. Make sure 'Display block count badge on shields button' works

Describe the issue you encountered: Rename general.blocked-count-badge to shields.blocked-count-badge.

browser-laptop/js/constants/appConfig.js

Line 133 in c5f4409

'general.blocked-count-badge': true,

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues:
@luixxiul luixxiul self-assigned this May 19, 2017
@luixxiul luixxiul added the polish Nice to have — usually related to front-end/visual tasks. label May 19, 2017
@luixxiul luixxiul added this to the 0.15.400 milestone May 19, 2017
@luixxiul luixxiul mentioned this issue May 21, 2017
Merged
7 tasks
This was referenced Jun 19, 2017
Closed
Closed
Closed
Closed
@Jacalz Jacalz mentioned this issue Jun 21, 2017
Closed
94 tasks
@alexwykoff alexwykoff mentioned this issue Jun 22, 2017
Closed
@LaurenWags LaurenWags mentioned this issue Jun 23, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
feature/shields polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.17.13 (Release Channel)
Development

No branches or pull requests
3 participants
@luixxiul @srirambv @LaurenWags