Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Pocket icon should change its color based on status #9157

Closed
luixxiul opened this issue May 31, 2017 · 2 comments
Closed

Pocket icon should change its color based on status #9157

luixxiul opened this issue May 31, 2017 · 2 comments

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered: #7357 (comment)

since other icons around the pocket one change color based on status. LastPass changes the color into yellow when the extension has a warning notification. Shield button changes its color too.

screenshot 2017-05-29 17 14 26 screenshot 2017-05-29 17 14 48

  • Brave Version (revision SHA): 0.15.310

  • Steps to reproduce:

    1. Enable Pocket
    2. Click the icon to save the page
  • Actual result: the color does not change.

  • Expected result: the icon color should change like other icons do.

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues:

@bsclifton
Copy link
Member

We're just displaying what the extension it telling us to- I don't think there's anything we can do (other than to ask the maintainers for the Pocket extension). @jonathansampson can you confirm?

@luixxiul
Copy link
Contributor Author

lately you get the red icon on macOS:

screenshot 2017-06-19 19 16 50

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants