Bug in client when no access token is provided

[raphaelrpl]

There is a bug in lccs.py when a request is made to LCCS Server without property access_token.

curl https://path/to/lccs/classification_systems?access_token=token_e

    return self.svc.lccs_ws.get_system_classification()
  File "/terra_collect/terra_collect/services/lccs_ws.py", line 51, in get_system_classification
    systems = lccs_service.classification_systems
  File "/usr/local/lib/python3.7/site-packages/lccs/lccs.py", line 90, in classification_systems
    return self._get_classification_systems()
  File "/usr/local/lib/python3.7/site-packages/lccs/lccs.py", line 61, in _get_classification_systems
    data = Utils._get(url)
  File "/usr/local/lib/python3.7/site-packages/lccs/utils.py", line 40, in _get
    response.raise_for_status()
  File "/usr/local/lib/python3.7/site-packages/requests/models.py", line 1021, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 404 Client Error: NOT FOUND for url: http://dev-lccs-ws:5000/classification_systems&language=pt-br

The error occurs due wrong usage of URI and parameters in request session.

For example:

lccs.py/lccs/lccs.py

Line 35 in 2f9b2bc

self._access_token = f'?access_token={access_token}' if access_token else ''

and here

lccs.py/lccs/lccs.py

Line 60 in 2f9b2bc

url = f'{self._url}/classification_systems{self._access_token}{self._language}'

You should use something like this

params = {"language": "pt-br"}
if self.access_token:
    params["access_token"] = self.access_token

session.get(SERVICE_RESOURCE_URL, params=params)

DO NOT manually concat these parameters in URL