You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
message=f'{name} is outdated (got version {module.__version__}, need version {version})'
ifprefs.core.outdated_dependency_error:
raiseImportError(message)
else:
logger.warn(message, 'outdated_dependency')
def_check_dependency_versions():
forname, versionin [('numpy', '1.10'),
('sympy', '1.2'),
('jinja2', '2.7')]:
_check_dependency_version(name, version)
_check_dependency_versions()
I'm not entirely convinced anymore that this is a good idea, so maybe we should simply remove these checks. But it would be good to have a look first how/if other packages are handling this. If we keep this, we should at least make sure that the checked requirements stay in sync with the actual requirements, by reading them in from some canonical source (requirements.txt, pyproject.toml, ...).
The text was updated successfully, but these errors were encountered:
Yes, I agree that this needs to be read in from another source if you want to keep it but provided the installed packages meet the minimum requirements to install & run Brian, maybe this should just be left to pip or conda to nag users to upgrade? The main reason I can imagine for this scenario (recommending but not requiring an upgrade) would be for better performance, however if it makes that much of a difference, maybe we should just bump the minimum requirements?
When importing the
brian2
package, we check a few packages for outdated versions:brian2/brian2/__init__.py
Lines 74 to 100 in 4886c46
I'm not entirely convinced anymore that this is a good idea, so maybe we should simply remove these checks. But it would be good to have a look first how/if other packages are handling this. If we keep this, we should at least make sure that the checked requirements stay in sync with the actual requirements, by reading them in from some canonical source (
requirements.txt
,pyproject.toml
, ...).The text was updated successfully, but these errors were encountered: