Carbon 1.26.0 breaks Laravel compability

[alshenetsky]

After composer update it says:

PHP Fatal error: Carbon\Carbon and Illuminate\Support\Traits\Macroable define the same property ($macros) in the composition of Illuminate\Support\Carbon. However, the definition differs and is considered incompatible.

Downgrade to 1.25.0 works fine

[Miguel-Serejo]

This is a Laravel issue, not a Carbon issue.

A quick glance at laravel's package.json shows a recent commit updated the dependency from "^1.24.1" to "1.25.*" which would fix this issue.

[kylekatarnls]

Very unexpected, I just upgraded a Laravel project with no problem. What is your Laravel and PHP version?

Making $macros private could be a possible fix.

[Miguel-Serejo]

Laravel 5.6.16 requires nesbot/carbon at "^1.24.1" which does try to pull 1.26.0, which is grossly incompatibly with Laravel's Carbon extension.

Current fix is to manually restrict carbon to "1.25.*" or lower in any laravel projects.

[kylekatarnls]

When did you get this error? on update, on run, on extend? I use Laravel 5.6 with Carbon 1.26 and PHP 7.2 just now and my macros work.

[Miguel-Serejo]

On updating an existing project. More specifically, on executing artisan package:discover to generate the autoload file.

[alshenetsky]

This error throws in runtime also, not just in console. It breaks entire project.

So we are supposed to wait for new release of Laravel? I see they already fixed a dependency

[Miguel-Serejo]

I'd just like to ask that you refrain from tagging a new release reverting these changes before speaking with Taylor to prevent a repeat of the last time there was a Laravel/Carbon compatibility issue.

[kylekatarnls]

We will use an other variable name. But I still do not understand, I just ran artisan package:discover and composer create-project laravel/laravel with no problem at all.

[kylekatarnls]

@36864 @alshenetsky Can you try if installing dev-master version solves the problem?

[alshenetsky]

Seems to be fixed. Thank you very much.