Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify/minimize crypto/bn #223

Closed
briansmith opened this issue Jun 20, 2016 · 1 comment
Closed

Simplify/minimize crypto/bn #223

briansmith opened this issue Jun 20, 2016 · 1 comment

Comments

@briansmith
Copy link
Owner

We should review the complicated code that does the various optimizations in crypto/bn and see what we can simplify without hurting keygen performance. In particular, is the Karatsuba multiplication (bn_mul_recursive) and/or Comba multiplication (bn_mul_comba4, bn_sqr_comba8, bn_sqr_comba4, etc.) actually useful, or is it just needless complexity?

We already made RSA signing and RSA verification independent from it, AFAICT. (That needs to be verified.) RSA key generation (#219) might need these optimizations?
@briansmith
Copy link
Owner Author

I'm going to close this. This will happen naturally as part of other work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@briansmith