Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Braces/brackets no longer around sets & arrays #1182

Closed
philrz opened this issue Nov 2, 2020 · 1 comment
Closed

Braces/brackets no longer around sets & arrays #1182

philrz opened this issue Nov 2, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@philrz
Copy link
Contributor

philrz commented Nov 2, 2020

This change in behavior has been confirmed to be coincidental with the changes in #1108 ("Brim ZJSON Update", cc: @jameskerr).

At Brim commit 4796f3d that was right before that PR, we were still using squiggly braces around sets and square brackets around arrays to clearly communicate their structure (i.e. so the user would less surprised at having to use the in operator to do searches against them as named fields), such as shown for tx_hosts / rx_hosts for Zeek files events in the first screenshot below.

image

But then with commit c3e0caa that's associated with #1108, the brackets are gone.

image

@philrz philrz added the bug Something isn't working label Nov 2, 2020
@philrz philrz added this to the Brim v0.19.0 milestone Nov 2, 2020
@philrz philrz modified the milestones: Brim v0.19.0, Brim v0.20.0 Nov 12, 2020
@jameskerr jameskerr self-assigned this Dec 21, 2020
@philrz philrz modified the milestones: Brim v0.22.0, Brim v0.24.0, Brim v0.25.0 Jan 5, 2021
@philrz philrz modified the milestones: Brim v0.25.0, Brim v0.26.0 Feb 9, 2021
@philrz philrz removed this from the Brim v0.26.0 milestone Mar 14, 2021
@philrz
Copy link
Contributor Author

philrz commented Sep 16, 2021

This was restored some time ago, I believe when the Zed type system was implemented in JS via #1603.

In any case, I can verify that it's present in current Brim commit 0dcf10c. Specifically, sets are rendered with the same |[ ]|as they appear in ZSON:

image

Likewise for arrays, these are rendered with [ ] as in ZSON.

image

Looking at it closely now, I happen to find the gray font of the brackets to be so light that it's a little difficult to see, but now that the detailed type info also appears when I hover with the mouse, there's multiple ways we're communicating it.

@philrz philrz closed this as completed Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants