Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up on CNN deprecation done in the update to python 3.10. #8907

Open
samuelklee opened this issue Jul 9, 2024 · 2 comments
Open

Follow up on CNN deprecation done in the update to python 3.10. #8907

samuelklee opened this issue Jul 9, 2024 · 2 comments
Assignees

Comments

@samuelklee
Copy link
Contributor

After the updates to the python environment made in #8561, the CNN tools are no longer functional and were deprecated.

However, we may want to provide a separate environment in which some of these tools can still be used, perhaps in conjunction with NVScoreVariants. If so, we should also re-enable the relevant integration and WDL tests and provide appropriate documentation.

@gokalpcelik
Copy link
Contributor

If we will get rid of those anyway can't we just provide a yml file with an unsupported yet minimal conda environment just to run old CNN tools (Neither we make it mandatory on the docker image nor we force people to install it). We should keep in mind that some of those libraries are pulled from the default channel which still raises questionable ethics for some.

@droazen
Copy link
Contributor

droazen commented Jul 10, 2024

Yes, the plan is to distribute the old environment as just a yml file that can be optionally activated -- provided that we can set up part of the test suite to run under the old environment, which is the next task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants