FlowFeatureMapper speed improvements #8982
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…easing cache size
ilyasoifer
reviewed
Sep 17, 2024
...adinstitute/hellbender/tools/walkers/featuremapping/FlowFeatureMapperArgumentCollection.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * do not emit edit distance at all | ||
| **/ | ||
| @Argument(fullName = "no-edit-distance", doc = "do not emit edit distance at all ?", optional = true) |
There was a problem hiding this comment.
Do we need this option?
There was a problem hiding this comment.
I imagine that these changes are going to raise some questions. Can you please add description in the PR?
| @@ -759,5 +886,35 @@ private FeatureMapper buildMapper() { | |||
| throw new GATKException("unsupported mappingFeature: " + fmArgs.mappingFeature); | |||
| } | |||
| } | |||
|
|
|||
| private FlowBasedRead buildTrimmedFlowBasedRead(final GATKRead read, final TrimInfo trimInfo, final FlowBasedReadUtils.ReadGroupInfo rgInfo) { | |||
There was a problem hiding this comment.
I think that this code might be duplicated.
HaplotypeCaller routinely trims reads. Could you check if there is a function like that?
There was a problem hiding this comment.
I have refactored this code to be closer in naming convention to its purpose
|
@ilyasoifer I have addressed your comments. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional changes include: