extract md5

[fanatid]

Why? Because you already extracted sha.js and ripemd160, but md5 is still here in files md5.js and make-hash.js. Also it's help with browserify/EVP_BytesToKey#3.

If you're agree I can create this package and then transfer to organization crypto-browserify.

[calvinmetcalf]

go for it

[fanatid]

Depends from browserify/sha.js#25

[fanatid]

@calvinmetcalf I extracted md5 -- http://github.com/fanatid/md5.js (based on hash-base -- http://github.com/fanatid/hash-base).
I also added you on npm! (You can add other crypto-browserify members and remove me, I don't object)

Can we discuss this packages? and after I'll continue with integration hash-base to sha.js and ripemd160..
I wanted transfer repositories, but found that I should have admin rights... :( but we can ask github support about this! repositories were moved

cc @dcousens @dominictarr @jprichardson

[calvinmetcalf]

md5 looks good

[fanatid]

@calvinmetcalf what you think about DEFAULT_ENCODING in hash-base?

[calvinmetcalf]

• why is it a static method on the creatHash class?
• it should be an if/else if not an if/if

[fanatid]

why is it a static method on the creatHash class?

it's static because in node crypto this is static
in createHash we can use getter/setter (and reassign in md5.js, sha.js, ripemd160)

it should be an if/else if not an if/if

if/if because we should change buffer -> binary (new Buffer('data', 'buffer') is invalid)

[calvinmetcalf]

so default encoding is on the crypto module not the individual modules, if we were to implement that I don't think this would be the way to do it

[fanatid]

yes, DEFAULT_ENCODING is top property and I don't know how implement this in small modules
should we support this feature?

[calvinmetcalf]

I will live if we don't, nobody has complained yet

[calvinmetcalf]

nodejs/node#6042

[dcousens]

Close in favour of #19