Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options.paths not used for transforms #150

Open
fk-hb opened this issue Jul 29, 2018 · 4 comments
Open

options.paths not used for transforms #150

fk-hb opened this issue Jul 29, 2018 · 4 comments

Comments

@fk-hb
Copy link

fk-hb commented Jul 29, 2018

Hi,
Is there any reason why you dont pass paths in loadTransforms?
I had some transforms installed in a separate directory referenced by NODE_PATH. node find them correctly but browserify not even if I pass that directory to the paths option of browserify.
I went down the calls until I found that the missing piece is to add paths: self.paths to the params variable in loadTransform.
By doing that, it now works but I don't know if this is the right solution.

@fk-hb
Copy link
Author

fk-hb commented Aug 14, 2018

Any reaction?

@goto-bus-stop
Copy link
Member

I've never used NODE_PATH and haven't got a clue, but it sounds like people who do use it generally expect it to apply to transforms too, so we should probably land one of the existing PRs that implements this.

#120
#92

@fk-hb
Copy link
Author

fk-hb commented Aug 15, 2018

I've seen there is already PRs for exactly this subject.
Both PRs have made the exact same modification as the one I made.
#120 contains test code.
#92 solves an another error: Error message will always contain undefined since it references the wrong variable.
If you should only accept one, then #120...

@fk-hb
Copy link
Author

fk-hb commented Sep 17, 2018

Hi @goto-bus-stop,
Do you know when you can accept of the PRs that solve this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants