Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken indicator insets #51

Open
kedio opened this issue Nov 11, 2015 · 1 comment
Open

Broken indicator insets #51

kedio opened this issue Nov 11, 2015 · 1 comment

Comments

@kedio
Copy link

kedio commented Nov 11, 2015

I don't know exactly what is happening but the #33 break the indicator insets for my UITableView. If I comment the line in scrollViewDidScroll in BLKFlexibleHeightBarBehaviorDefiner then the indicator insets are as expected.

My setup:
A flexibleHeightBar and a tableView are subviews of a UIViewController
I use autoLayout and all my constraints are define in code

@kedio kedio changed the title Broken indicator insets when Bar is not a UITableView subviews Broken indicator insets when Bar is not a UITableViewController subviews Nov 11, 2015
@kedio kedio changed the title Broken indicator insets when Bar is not a UITableViewController subviews Broken indicator insets Nov 11, 2015
@kedio
Copy link
Author

kedio commented Nov 11, 2015

Seems I was setting constraints so my tableView would start just under the FlexibleHeightBar, but it seems it is intended as #33 that the FlexibleHeightBar must overlay the tableView and a contentInset must be set.

_tableView.contentInset = UIEdgeInsetsMake(_headerView.maximumBarHeight, 0.0, GlobalMetrics.LARGE_HORIZONTAL_MARGIN, 0.0)

With this it is working as intended it even fixed some flickering I was experiencing while scrolling. The doc should just be more expressive about this fact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant