-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency in storage interfaces #675
Comments
This seems like a good idea. I seem to remember returning |
Also, existing storages has functions to set data for unit tests (such as |
I disagree with this second request. These are convenience functions, and if you add your own storage classes, you are free to add these functions or not. The library classes require them for testing, but the actual OAuth server does not require them. |
Somewhere function must return
false
if value not exist (ClientInterface::getClientDetails()
)Somewhere function must return
null
in such case (AuthorizationCodeInterface::getAuthorizationCode()
)Somewhere behavior not defined (
PublicKeyInterface::getPrivateKey()
)I suggest to revise interfaces and
return
null
if value not exist (not defined)return
false
on errorThe text was updated successfully, but these errors were encountered: