Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InventoryFile ~appears to be equipped to~ *cannot* handle an empty dispname #190

Closed
2 tasks done
bskinn opened this issue Feb 8, 2021 · 0 comments · Fixed by #189
Closed
2 tasks done

InventoryFile ~appears to be equipped to~ *cannot* handle an empty dispname #190

bskinn opened this issue Feb 8, 2021 · 0 comments · Fixed by #189
Labels
type: enhancement ✨ Something to add
Milestone
v2.1

Comments

@bskinn
Copy link
Owner

bskinn commented Feb 8, 2021 •
edited
Loading

At least, according to the regex.

CORRECTION: Nope! The .rstrip() applied to the data line contents makes the regex fail if there's no dispname.
@bskinn bskinn added the type: enhancement ✨ Something to add label Feb 8, 2021
@bskinn bskinn added this to the v2.1 milestone Feb 8, 2021
@bskinn bskinn mentioned this issue Feb 8, 2021
Merged
@bskinn bskinn changed the title InventoryFile appears to be equipped to handle an empty dispname InventoryFile ~appears to be equipped to~ cannot handle an empty dispname Mar 29, 2024
@bskinn bskinn changed the title InventoryFile ~appears to be equipped to~ cannot handle an empty dispname InventoryFile ~appears to be equipped to~ *cannot* handle an empty dispname Mar 29, 2024
@bskinn bskinn mentioned this issue Mar 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement ✨ Something to add
Projects
None yet
Milestone
v2.1
Development

Successfully merging a pull request may close this issue.

Add crosschecks for objects & counts between Sphinx and sphobjinv parsing bskinn/sphobjinv
1 participant
@bskinn