Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected breaking change in URL encoding. #46

Open
lzl124631x opened this issue Dec 1, 2020 · 0 comments
Open

Unexpected breaking change in URL encoding. #46

lzl124631x opened this issue Dec 1, 2020 · 0 comments

Comments

@lzl124631x
Copy link

lzl124631x commented Dec 1, 2020 •
edited
Loading

Expected

1.2.1: https://codesandbox.io/s/reach-router-starter-v1-forked-vsw3w?file=/src/index.js

after calling navigate(encodeURIComponent("foo$bar"));, I was brought to /foo%24bar

Actual

1.3.4: https://codesandbox.io/s/reach-router-starter-v1-forked-1fyh2?file=/src/index.js

after calling navigate(encodeURIComponent("foo$bar"));, I was brought to /foo%2524bar

After trying several versions, this issue was introduced in 1.3.3.
@lzl124631x lzl124631x changed the title Unexpected breacking change in URL encoding. Unexpected breaking change in URL encoding. Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lzl124631x