-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to arm64 #75
Comments
Hm, that script is only run in the context of building the Docker image for the purposes of testing. However, for Envoy and in general, PGV uses Bazel. I'd look at those build rules and ensure that they are compatible with arm64. Will be glad to help if you can pinpoint the issues! |
As @rodaine points out the container build script isn't the source of the problem. I expect the issue is somewhere in https://github.com/lyft/protoc-gen-validate/tree/master/bazel. There are bunch of work arounds for since fixed issues and some of the dependencies are quite old. Still digging. |
@moderation and I chatted offline and it looks like the current blocker is a bug in rules_go repository's support for arm64 go toolchain versions. The issue is that if repository_ctx.os.name is 'linux', there's no way to set the host as |
The upstream issue on bazel has been resolved. |
In envoyproxy/envoy#1861 (comment) , @moderation is attempting a port of Envoy to arm64. After getting pretty far they got stuck in a dependency on lyft/protoc-gen-validate.
I suspect that one of the issues is a hardcoded dependency to arm64 binaries in the build_container script at
https://github.com/lyft/protoc-gen-validate/blob/master/scripts/build_container.sh#L18
https://github.com/lyft/protoc-gen-validate/blob/master/scripts/build_container.sh#L38
However there may be more issues lurking; using this issue to track them.
The text was updated successfully, but these errors were encountered: