From afe6f5e8188c3fddbfdcabacdf6e458a6e50e827 Mon Sep 17 00:00:00 2001
From: Ben Gourley <bn@grly.me>
Date: Tue, 29 Jan 2019 13:49:17 +0000
Subject: [PATCH] feat(delivery-node): Include error stack in first argument to
 logger

Some loggers only use the first argument passed, in which cases the actual cause of the error would
be lost.
---
 packages/delivery-node/delivery.js | 26 ++++++++++++++------------
 1 file changed, 14 insertions(+), 12 deletions(-)

diff --git a/packages/delivery-node/delivery.js b/packages/delivery-node/delivery.js
index 876041218f..f39a20daef 100644
--- a/packages/delivery-node/delivery.js
+++ b/packages/delivery-node/delivery.js
@@ -4,6 +4,11 @@ const request = require('./request')
 
 module.exports = () => ({
   sendReport: (logger, config, report, cb = () => {}) => {
+    const _cb = err => {
+      if (err) logger.error(`Report failed to send…\n${(err && err.stack) ? err.stack : err}`, err)
+      cb(err)
+    }
+
     try {
       request({
         url: config.endpoints.notify,
@@ -15,16 +20,17 @@ module.exports = () => ({
         },
         body: payload.report(report, config.filters),
         agent: config.agent
-      }, (err, body) => {
-        if (err) logger.error('Report failed to send…', err)
-        cb(err)
-      })
+      }, (err, body) => _cb(err))
     } catch (e) {
-      logger.error(e)
-      cb(e)
+      _cb(e)
     }
   },
   sendSession: (logger, config, session, cb = () => {}) => {
+    const _cb = err => {
+      if (err) logger.error(`Session failed to send…\n${(err && err.stack) ? err.stack : err}`, err)
+      cb(err)
+    }
+
     try {
       request({
         url: config.endpoints.sessions,
@@ -36,13 +42,9 @@ module.exports = () => ({
         },
         body: payload.session(session, config.filters),
         agent: config.agent
-      }, err => {
-        if (err) logger.error('Session failed to send…', err)
-        cb(err)
-      })
+      }, err => _cb(err))
     } catch (e) {
-      logger.error(e)
-      cb(e)
+      _cb(e)
     }
   }
 })