Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make retrieval of server variables pluggable #99

Closed
atrauzzi opened this issue Oct 5, 2015 · 4 comments
Closed

Make retrieval of server variables pluggable #99

atrauzzi opened this issue Oct 5, 2015 · 4 comments
Assignees

Comments

@atrauzzi
Copy link

atrauzzi commented Oct 5, 2015

We're currently using bugsnag on a google app engine application using Laravel.

Unfortunately, the following line is causing us some issues: https://github.com/bugsnag/bugsnag-php/blob/master/src/Bugsnag/Request.php#L62

Now, given that this isn't bugsnag-laravel, I understand that we can't leverage any of the configuration or request/response libraries. Although it would be ideal if the mechanism used to obtain values like these was pluggable. Then, bugsnag-laravel could ship an implementation that retrieves the variables from its own abstraction. Then, bugsnag-php can ship defaults that use the superglobals.

@GrahamCampbell GrahamCampbell self-assigned this Jun 22, 2016
@GrahamCampbell
Copy link
Contributor

Thanks. I definitely plan to get this implemented in v3.

@GrahamCampbell
Copy link
Contributor

Going to implement this using a request resolver to resolve a request object.

@GrahamCampbell
Copy link
Contributor

If there's no request, we can have a nulled object.

@GrahamCampbell
Copy link
Contributor

Will land in 3.x shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants