Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Journey test failure because build label was "missing" in the preview #327

Closed
GentlemanHal opened this issue Feb 7, 2021 · 0 comments
Closed
Assignees
Labels
bug Something isn't working as expected for developers Changes that make development easier

Comments

@GentlemanHal
Copy link
Member

The test toggles display settings and uses the preview to verify they are working correctly. In this case the preview didn't generate any broken builds that were shown outside the summary, which meant the build label (which isn't shown for building projects due to how the CCTray XML is updated) was missing as far as the test was concerned.

This isn't a major issue, but it does suck the tests might falsely fail randomly.

I don't think I want to complicate the test to retry or anything, unless this starts happening more frequently. Perhaps a better idea is to improve the preview to make it more consistent 🤔

@GentlemanHal GentlemanHal added bug Something isn't working as expected for developers Changes that make development easier labels Feb 7, 2021
@GentlemanHal GentlemanHal self-assigned this Oct 17, 2021
GentlemanHal added a commit that referenced this issue Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected for developers Changes that make development easier
Projects
None yet
Development

No branches or pull requests

1 participant