Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipeline upload should refuse to upload pipelines containing redacted-vars #1469

Closed
keithduncan opened this issue Jul 22, 2021 · 0 comments · Fixed by #1523
Closed

pipeline upload should refuse to upload pipelines containing redacted-vars #1469

keithduncan opened this issue Jul 22, 2021 · 0 comments · Fixed by #1523
Assignees
@keithduncan @eleanorakh
Labels
good-first-issue

Comments

@keithduncan
Copy link
Contributor

It’s possible to leak vars that are redacted from logs by uploading an interpolated pipeline that uses them.

The pipeline upload command could scan the received pipeline for any secret values and refuse to upload it if present, and print an error explaining why.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keithduncan keithduncan

@eleanorakh eleanorakh

Labels
good-first-issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reject pipeline uploads containing redacted vars buildkite/agent
2 participants
@keithduncan @eleanorakh