Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image env flag only appends env vars #230

Open
tylerphelan opened this issue Dec 14, 2021 · 1 comment
Open

image env flag only appends env vars #230

tylerphelan opened this issue Dec 14, 2021 · 1 comment

Comments

@tylerphelan
Copy link
Contributor

tylerphelan commented Dec 14, 2021

kp image save ... --env FOO=BAR will only append the FOO environment variable to the list of vars on the image resource. This may not be the behavior we want.

Kpack issue: buildpacks-community/kpack#895

@sambhav
Copy link

sambhav commented Dec 14, 2021

We do rely on this behavior currently and instead use --delete-env to delete things that are not needed. This might cause breakages for users who rely on this in CI/CD envs. for eg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants