keltner_channel_hband incorrect output?

[khoing1111]

I take a look at the following code

https://github.com/bukosabino/ta/blob/0.5.11/ta/volatility.py

line 210

It look weird that keltner_channel_hband use self._tp instead of self._tp_high?

    def keltner_channel_hband(self) -> pd.Series:
        """Keltner Channel High Band
        Returns:
            pandas.Series: New feature generated.
        """
        tp = self._check_fillna(self._tp, value=-1)
        return pd.Series(tp, name='kc_hband')

[bukosabino]

Hi @khoing1111 ,

You are right. I will fix it asap.

Best,
Dario

[bukosabino]

5438c94

fixing bug: keltner channel high band calculation. Also, included percentage band and width band indicators for keltner channel. Also, included 2 ways to calculate the centerline of Keltner Channel: original version (sma of typical price) vs modern version (ema of close)

[bukosabino]

The last library version (0.5.15) includes this feature.

pip install -U ta

Thanks @khoing1111