Fix precedence of negation vs comparison #69
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed antlr grammar to correctly prioritize negation vs comparison when parsing.
Before fix, expression
!foo == 'bar'
was parsed into:After fix, expression
!foo == 'bar'
is parsed into:Taking the JS implementation as the source of truth, because it prioritizes negation vs comparison. Example:
First
foo
(which is equal to 1) is negated, resulting infalse
. Then, the result is compared totrue
, so the final result isfalse
. Before the fix, this Java implementation would returntrue
for the same expression, because first foo is compared totrue
, which results infalse
(because1 != true
) and the result is negated, resulting intrue
.