+
+
| Avoid 🔥[Link](../docs/something.png) |
|---|
| + +```go +resp, err := http.Get("http://example.com/") +if err != nil { + // handle... +} +defer runutil.CloseWithLogOnErr(logger, resp.Body, "close response") + +scanner := bufio.NewScanner(resp.Body) +// If any error happens and we return in the middle of scanning +// body, we can end up with unread buffer, which +// will use memory and hold TCP connection! +for scanner.Scan() { +``` + + |
| Better 🤓 |
+
@@ -227,6 +227,41 @@ The compactor is not in the critical path of querying or data backup. It can eit
In case of Prometheus with Thanos sidecar does not have enough retention, or if you want to have alerts or recording rules that requires global view, Thanos has just the component for that: the [Ruler]($$-components/rule.md-testdata/not_formatted.md-$$), which does rule and alert evaluation on top of a given Thanos Querier.
+
+
+
+
+
| Avoid 🔥[Link](../docs/something.png) |
|---|
| + +```go +resp, err := http.Get("http://example.com/") +if err != nil { + // handle... +} +defer runutil.CloseWithLogOnErr(logger, resp.Body, "close response") + +scanner := bufio.NewScanner(resp.Body) +// If any error happens and we return in the middle of scanning +// body, we can end up with unread buffer, which +// will use memory and hold TCP connection! +for scanner.Scan() { +``` + + |
| Better 🤓 |
+
+
| Avoid 🔥[Link](../docs/something.png) |
|---|
| + +```go +resp, err := http.Get("http://example.com/") +if err != nil { + // handle... +} +defer runutil.CloseWithLogOnErr(logger, resp.Body, "close response") + +scanner := bufio.NewScanner(resp.Body) +// If any error happens and we return in the middle of scanning +// body, we can end up with unread buffer, which +// will use memory and hold TCP connection! +for scanner.Scan() { +``` + + |
| Better 🤓 |