Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove localtunnel integration #36

Open
naholyr opened this issue Nov 8, 2017 · 0 comments
Open

Remove localtunnel integration #36

naholyr opened this issue Nov 8, 2017 · 0 comments

Comments

@naholyr
Copy link
Member

naholyr commented Nov 8, 2017

localtunnel has not been very reliable during tests, so it may be a good idea to just remove it. However, it brings some issues:

  • Client-side must be modified when using a tunnel, so we have to add a test in client to drop websocket support when using such tunnel:
    if (document.location.hostname.match(/(\.localtunnel\.me|\.ngrok\.io)$/)) {
    // Websocket transports screws the whole thing when tunnelling through localtunnel
    socketOptions = { transports: ['polling'] }
    }
    • Solution would be to just drop websocket support when hostname is not an IP address?
    • Maybe upgrading to socket.io 2.x would fix it
  • Tunnel's hostname is an interesting thing to store so we can reuse it when restarting, in our localtunnel integration we just let it be randomly generated first time then store it in a file to reuse the same one on next starts: user doesn't have to choose a hostname, but does not lose the permanent url
    • I think we can just drop this and have user use his tunnel tool and choose himself the hostname if he wants it to be permanent, useless feature imo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant