Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wac-graph: defined types need dependency edges to other defined types #78

Closed
peterhuene opened this issue Apr 12, 2024 · 1 comment · Fixed by #82
Closed

wac-graph: defined types need dependency edges to other defined types #78

peterhuene opened this issue Apr 12, 2024 · 1 comment · Fixed by #82
Assignees
Labels
bug Something isn't working

Comments

@peterhuene
Copy link
Member

peterhuene commented Apr 12, 2024

Currently CompositionGraph::define_type allows for exporting a named type from the composition.

However, the node it creates in the graph has no dependency edges on other defined types that might be referenced from the type definition.

The result is that the toposort performed when the graph is encoded does not properly order the types such that they are in correct topological order (although the ordering is a stable one).

The fix is to add a "depends on" edge from the node to any defined type referenced from the type being defined.

@peterhuene peterhuene self-assigned this Apr 12, 2024
@peterhuene
Copy link
Member Author

I have a fix for this with the upcoming wac-parser resolution rewrite.

@peterhuene peterhuene added the bug Something isn't working label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant