Improve WASI thread id allocator to reuse identifiers #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamt
reviewed
Dec 14, 2022
yamt
reviewed
Dec 14, 2022
core/iwasm/libraries/lib-wasi-threads/lib_wasi_threads_wrapper.c
Outdated
Show resolved
Hide resolved
core/iwasm/libraries/lib-wasi-threads/lib_wasi_threads_wrapper.c
Outdated
Show resolved
Hide resolved
core/iwasm/libraries/lib-wasi-threads/lib_wasi_threads_wrapper.c
Outdated
Show resolved
Hide resolved
loganek
reviewed
Dec 14, 2022
core/iwasm/libraries/lib-wasi-threads/lib_wasi_threads_wrapper.c
Outdated
Show resolved
Hide resolved
loganek
reviewed
Dec 14, 2022
core/iwasm/libraries/lib-wasi-threads/lib_wasi_threads_wrapper.c
Outdated
Show resolved
Hide resolved
eloparco
force-pushed
the
eloparco/thread-id-allocator
branch
2 times, most recently
from
26f72a6
to
3b4ff81
Compare
loganek
reviewed
Dec 14, 2022
core/iwasm/libraries/lib-wasi-threads/lib_wasi_threads_wrapper.c
Outdated
Show resolved
Hide resolved
|
I'm doing some additional refactoring to have both |
eloparco
force-pushed
the
eloparco/thread-id-allocator
branch
from
3b4ff81
to
7e32b7d
Compare
yamt
requested changes
Dec 15, 2022
core/iwasm/libraries/lib-wasi-threads/lib_wasi_threads_wrapper.c
Outdated
Show resolved
Hide resolved
core/iwasm/libraries/lib-wasi-threads/lib_wasi_threads_wrapper.c
Outdated
Show resolved
Hide resolved
core/iwasm/libraries/lib-wasi-threads/lib_wasi_threads_wrapper.c
Outdated
Show resolved
Hide resolved
core/iwasm/libraries/lib-wasi-threads/lib_wasi_threads_wrapper.c
Outdated
Show resolved
Hide resolved
loganek
reviewed
Dec 15, 2022
| if (avail_tids.pos == 0) { // Resize stack and push new thread ids | ||
| uint32 old_size = avail_tids.size; | ||
| uint32 new_size = avail_tids.size * 2; | ||
| if (new_size / 2 != avail_tids.size) { |
There was a problem hiding this comment.
[minor] you might just compare old_size with the new_size to avoid additional division.
There was a problem hiding this comment.
I used the division to make it similar to L54. I'm not sure a simple comparison would work for L54 (maybe when overflowing/wrapping the result can be bigger than the initial value?)
There was a problem hiding this comment.
yes, one way to detect integer overflow here is to check if new_size < avail_tids.size. It's not a major callout though.
loganek
reviewed
Dec 15, 2022
core/iwasm/libraries/lib-wasi-threads/lib_wasi_threads_wrapper.c
Outdated
Show resolved
Hide resolved
loganek
requested changes
Dec 15, 2022
core/iwasm/libraries/lib-wasi-threads/lib_wasi_threads_wrapper.c
Outdated
Show resolved
Hide resolved
eloparco
force-pushed
the
eloparco/thread-id-allocator
branch
from
7e32b7d
to
6c25253
Compare
wenyongh
reviewed
Dec 16, 2022
yamt
approved these changes
Dec 16, 2022
| goto return_id; | ||
| } | ||
| int32 *tmp = | ||
| (int32 *)wasm_runtime_realloc(avail_tids.ids, realloc_size); |
There was a problem hiding this comment.
Should I get rid of it? I put it (and same for the malloc) for consistency with the rest of the codebase
eloparco
changed the title
loganek
approved these changes
Dec 18, 2022
eloparco
force-pushed
the
eloparco/thread-id-allocator
branch
from
6c25253
to
867954a
Compare
|
@wenyongh fixed the conflicts, I think we can merge it now |
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…ytecodealliance#1809) This PR allows reusing thread ids once they are released. That is done by using a stack data structure to keep track of the used ids. When a thread is created, it takes an available identifier from the stack. When the thread exits, it returns the id to the stack of available identifiers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, when created, a thread receives an incremental number as an identifier.
This PR allows reusing thread ids once they are released. That is done by using a stack data structure to keep track of the used ids.
When a thread is created, it takes an available identifier from the stack. When the thread exits, it returns the id to the stack of available identifiers.