Big Endian

[lehins]

I'd like to point out that there is a bug in ghc <8 .10 that makes this code to not work correctly on Big Endian machines: https://gitlab.haskell.org/ghc/ghc/-/issues/20338

Code that uses buggy targetByteOrder function is here https://github.com/byteverse/bytesmith/blob/master/src/Data/Bytes/Parser/BigEndian.hs

@andrewthad I am sure you knew about this, since you opened https://gitlab.haskell.org/ghc/ghc/-/issues/18445 but I wanted to bring it up anyways, since I found it in github search.

[andrewthad]

Is it only GHCs prior to 8.10 or including the 8.10.x series? Fortunately, I only develop for little-endian machines, so this does not affect me. Is there a recommended fix?

[lehins]

Fortunately, I only develop for little-endian machines

As everyone else in the universe 😄

It seems that ghc-8.10 had the fix implemented. So the only recommended way I see right now for dealing with this in libraries is to either have base >= 4.14 in cabal file or use CPP.