Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutations tab improvement #65

Closed
jjgao opened this issue Feb 28, 2019 · 9 comments
Closed

Mutations tab improvement #65

jjgao opened this issue Feb 28, 2019 · 9 comments
Labels
cBioPortal GSoC-2020 GSoC 2020 Candidate Projects Javascript

Comments

@jjgao
Copy link
Member

jjgao commented Feb 28, 2019

Background:
The Mutations tab in Results page is very useful for studying details about mutations. But it has it's limitation, for example, only one filter/search is allowed.

image

We would like to enhance the functionality of this page including improving its filtering/searching capability and options to load clinical attributes.

Goal:

  • Implement an option to load clinical attributes
  • Improving filtering/searching

Approach:

  • To implement the option to load clinical attributes, we can use the same component of "Add Chart" used in Study View. A column should be added per selected attribute in the mutations table.

image

  • Currently, we only list number of mutation by it type, ie. missense, truncating, inframe and other, and allow filtering by type. It would be useful to list and filter by any column in the table (including selected clinical attribute).
    • We might want to consider change the representation to a bar/column chart.
    • Multiple filters should be supported.
    • Filter and table search should be supported simultaneously.

Need skills:

Javascript, REACT

Possible mentors:
@Luke-Sikina @sheridancbio

@ArexJambusarwala
Copy link

Hey, I am a second year B-Tech student at DAIICT and am aiming for GSOC'19. This issue has caught my eye and I would like to work on it. I have been working on front-end technologies like HTML5/CSS, Javascript and React for over two years. I also have created websites from scratch using these technologies along with PHP. I believe I can make a significant contribution to this project and would like to know how to proceed further with the same. Thanks!

@jjgao
Copy link
Member Author

jjgao commented Mar 11, 2019

@ArexJambusarwala thanks for your interest. Looking forward to seeing your proposal.

@coderrsid
Copy link

Hey @jjgao I have sent you my proposal for this issue on Slack direct message. Can you please review it? and can you please tell me if i could mail you the proposal too?

@coderrsid
Copy link

Hey @jjgao @inodb I got a little late to submit the proposal because i went to a hackathon outside the city but please consider my proposal too and i have added mockups of filter as @inodb wanted.

@inodb
Copy link
Member

inodb commented Jan 15, 2020

@onursumer you think this is feasible for GSoC2020?

@onursumer
Copy link
Member

@inodb Multiple/simultaneous filter support has already been added and currently functional. We should update the project description to reflect the latest state of the mutations tab.

Implementing UI for additional filter options, like filtering by different columns, should be straightforward now. I am not sure though how much effort required to load clinical attributes.

@onursumer
Copy link
Member

Maybe we can also include cBioPortal/cbioportal/issues/5607 as part of this. @inodb, @jjgao, what do you think?

@jjgao
Copy link
Member Author

jjgao commented Jan 20, 2020

@onursumer good idea 👍

@ao508 ao508 added the GSoC-2020 GSoC 2020 Candidate Projects label Jan 24, 2020
@sheridancbio
Copy link

I have added myself as a possible mentor ... although I would not be good as the primary/sole mentor. If I participate I will also be improving my knowledge of our frontend/react development.

@inodb inodb closed this as completed Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cBioPortal GSoC-2020 GSoC 2020 Candidate Projects Javascript
Projects
None yet
Development

No branches or pull requests

7 participants