Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Handling of 5'Flank Mutation Type with Custom Filtered Mutations #65

Open
forus opened this issue Nov 1, 2024 · 0 comments

Comments

@forus
Copy link
Contributor

forus commented Nov 1, 2024

Currently, the handling of mutation records with the 5'Flank mutation type differs based on whether custom filtered mutations are specified. Here’s the observed behavior:

Default Filtered Mutations:
When using the default filtered mutations, the 5'Flank mutation is selected, and the protein change field is set to "Promoter" specifically for the TERT gene. This is achieved via a check against whiteListGenesForPromoterMutations (see MutationFilter.java#L150).

Custom Filtered Mutations:
When a custom mutation filter list is applied, the whiteListGenesForPromoterMutations check is skipped, resulting in different handling for 5'Flank mutations (see MutationFilter.java#L133).

This asymmetry in behavior seems unintended and could lead to inconsistent mutation handling depending on the filter setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant