diff --git a/end-to-end-test/local/specs/core/querypage.spec.js b/end-to-end-test/local/specs/core/querypage.spec.js index 79411d2de43..ef4ee208095 100644 --- a/end-to-end-test/local/specs/core/querypage.spec.js +++ b/end-to-end-test/local/specs/core/querypage.spec.js @@ -11,7 +11,7 @@ describe('study select page', function() { describe('error messaging for invalid study id(s)', function(){ it('show error alert and query form for single invalid study id',function(){ - var url = `${CBIOPORTAL_URL}/results/oncoprint?Z_SCORE_THRESHOLD=2.0&cancer_study_id=coadread_tcga_pub&cancer_study_list=coadread_tcga_pub&case_ids=&case_set_id=coadread_tcga_pub_nonhypermut&gene_list=KRAS%20NRAS%20BRAF&gene_set_choice=user-defined-list&genetic_profile_ids_PROFILE_COPY_NUMBER_ALTERATION=coadread_tcga_pub_gistic&genetic_profile_ids_PROFILE_MUTATION_EXTENDED=coadread_tcga_pub_mutations`; + var url = `${CBIOPORTAL_URL}/results/oncoprint?Z_SCORE_THRESHOLD=2.0&cancer_study_id=coadread_tcga_pub&cancer_study_list=coadread_tcga_pub&case_set_id=coadread_tcga_pub_nonhypermut&gene_list=KRAS%20NRAS%20BRAF&gene_set_choice=user-defined-list&genetic_profile_ids_PROFILE_COPY_NUMBER_ALTERATION=coadread_tcga_pub_gistic&genetic_profile_ids_PROFILE_MUTATION_EXTENDED=coadread_tcga_pub_mutations`; goToUrlAndSetLocalStorage(url); $('[data-test="StudySelect"]').waitForExist(); assert( $('[data-test="unkown-study-warning"]').$('li=coadread_tcga_pubb') ); diff --git a/end-to-end-test/remote/specs/core/coexpression.screenshot.spec.js b/end-to-end-test/remote/specs/core/coexpression.screenshot.spec.js index 06762c0e253..bc314736055 100644 --- a/end-to-end-test/remote/specs/core/coexpression.screenshot.spec.js +++ b/end-to-end-test/remote/specs/core/coexpression.screenshot.spec.js @@ -19,7 +19,7 @@ describe("coexpression tab screenshot tests", function() { this.retries(2); before(function() { - var url = `${CBIOPORTAL_URL}/results/coexpression?tab_index=tab_visualize&cancer_study_list=coadread_tcga_pub&cancer_study_id=coadread_tcga_pub&genetic_profile_ids_PROFILE_MUTATION_EXTENDED=coadread_tcga_pub_mutations&genetic_profile_ids_PROFILE_COPY_NUMBER_ALTERATION=coadread_tcga_pub_gistic&Z_SCORE_THRESHOLD=2.0&case_set_id=coadread_tcga_pub_nonhypermut&case_ids=&gene_list=KRAS+NRAS+BRAF&gene_set_choice=user-defined-list&Action=Submit`; + var url = `${CBIOPORTAL_URL}/results/coexpression?tab_index=tab_visualize&cancer_study_list=coadread_tcga_pub&cancer_study_id=coadread_tcga_pub&genetic_profile_ids_PROFILE_MUTATION_EXTENDED=coadread_tcga_pub_mutations&genetic_profile_ids_PROFILE_COPY_NUMBER_ALTERATION=coadread_tcga_pub_gistic&Z_SCORE_THRESHOLD=2.0&case_set_id=coadread_tcga_pub_nonhypermut&gene_list=KRAS+NRAS+BRAF&gene_set_choice=user-defined-list&Action=Submit`; goToUrlAndSetLocalStorage(url); }); it('coexpression tab coadread_tcga_pub initial load', function() { diff --git a/end-to-end-test/remote/specs/core/mutationTable.spec.js b/end-to-end-test/remote/specs/core/mutationTable.spec.js index b9860ef5ca7..00a2d6ef78b 100644 --- a/end-to-end-test/remote/specs/core/mutationTable.spec.js +++ b/end-to-end-test/remote/specs/core/mutationTable.spec.js @@ -18,7 +18,7 @@ describe('Mutation Table', function() { describe('try getting exon and hgvsc info from genome nexus', ()=>{ before(()=>{ - var url = `${CBIOPORTAL_URL}/results/mutations?Action=Submit&Z_SCORE_THRESHOLD=1.0&cancer_study_id=gbm_tcga_pub&cancer_study_list=gbm_tcga_pub&case_ids=&case_set_id=gbm_tcga_pub_sequenced&clinicallist=PROFILED_IN_gbm_tcga_pub_cna_rae&gene_list=TP53%20MDM2%20MDM4&gene_set_choice=user-defined_list&genetic_profile_ids_PROFILE_COPY_NUMBER_ALTERATION=gbm_tcga_pub_cna_rae&genetic_profile_ids_PROFILE_MUTATION_EXTENDED=gbm_tcga_pub_mutations&show_samples=false`; + var url = `${CBIOPORTAL_URL}/results/mutations?Action=Submit&Z_SCORE_THRESHOLD=1.0&cancer_study_id=gbm_tcga_pub&cancer_study_list=gbm_tcga_pub&case_set_id=gbm_tcga_pub_sequenced&clinicallist=PROFILED_IN_gbm_tcga_pub_cna_rae&gene_list=TP53%20MDM2%20MDM4&gene_set_choice=user-defined_list&genetic_profile_ids_PROFILE_COPY_NUMBER_ALTERATION=gbm_tcga_pub_cna_rae&genetic_profile_ids_PROFILE_MUTATION_EXTENDED=gbm_tcga_pub_mutations&show_samples=false`; goToUrlAndSetLocalStorage(url); // mutations table should be visiable after oncokb icon shows up, diff --git a/end-to-end-test/remote/specs/core/oncoprint.screenshot.spec.js b/end-to-end-test/remote/specs/core/oncoprint.screenshot.spec.js index 1244a017a54..d40ebda5d6a 100644 --- a/end-to-end-test/remote/specs/core/oncoprint.screenshot.spec.js +++ b/end-to-end-test/remote/specs/core/oncoprint.screenshot.spec.js @@ -11,6 +11,20 @@ const CBIOPORTAL_URL = process.env.CBIOPORTAL_URL.replace(/\/$/, ""); const ONCOPRINT_TIMEOUT = 60000; +function getNthTrackOptionsElements(n) { + // n is one-indexed + + const button_selector = "#oncoprintDiv .oncoprintjs__track_options__toggle_btn_img.nth-"+n; + const dropdown_selector = "#oncoprintDiv .oncoprintjs__track_options__dropdown.nth-"+n; + + return { + button: $(button_selector), + button_selector, + dropdown: $(dropdown_selector), + dropdown_selector + }; +} + describe("oncoprint screenshot tests", function() { it("coadread_tcga_pub with clinical and heatmap tracks", function(){ var url = `${CBIOPORTAL_URL}/index.do?cancer_study_id=coadread_tcga_pub&Z_SCORE_THRESHOLD=1&RPPA_SCORE_THRESHOLD=2&data_priority=0&case_set_id=coadread_tcga_pub_nonhypermut&gene_list=KRAS%20NRAS%20BRAF&geneset_list=%20&tab_index=tab_visualize&Action=Submit&genetic_profile_ids_PROFILE_MUTATION_EXTENDED=coadread_tcga_pub_mutations&genetic_profile_ids_PROFILE_COPY_NUMBER_ALTERATION=coadread_tcga_pub_gistic&genetic_profile_ids_PROFILE_MRNA_EXPRESSION=coadread_tcga_pub_rna_seq_mrna_median_Zscores&show_samples=false&clinicallist=0%2C2%2CMETHYLATION_SUBTYPE&heatmap_track_groups=coadread_tcga_pub_rna_seq_mrna_median_Zscores%2CKRAS%2CNRAS%2CBRAF&`; @@ -93,11 +107,23 @@ describe("oncoprint screenshot tests", function() { var res = checkOncoprintElement('.oncoprintContainer'); assertScreenShotMatch(res); }); + it("removes top treatment track successfully", function() { + goToUrlAndSetLocalStorage(`${CBIOPORTAL_URL}/results/oncoprint?Action=Submit&RPPA_SCORE_THRESHOLD=2.0&Z_SCORE_THRESHOLD=2.0&cancer_study_list=ccle_broad_2019&case_set_id=ccle_broad_2019_cnaseq&data_priority=0&gene_list=TP53&geneset_list=%20&genetic_profile_ids_PROFILE_COPY_NUMBER_ALTERATION=ccle_broad_2019_cna&genetic_profile_ids_PROFILE_MUTATION_EXTENDED=ccle_broad_2019_mutations&profileFilter=0&tab_index=tab_visualize&heatmap_track_groups=ccle_broad_2019_CCLE_drug_treatment_IC50%2CAfatinib-2%2CAKTinhibitorVIII-1&treatment_list=Afatinib-2%3BAKTinhibitorVIII-1`); + waitForOncoprint(ONCOPRINT_TIMEOUT); + + const elements = getNthTrackOptionsElements(2); + setDropdownOpen(true, elements.button_selector, elements.dropdown_selector, "Couldnt open top treatment track options"); + browser.click(elements.dropdown_selector + ' li:nth-child(3)'); // Click Remove + waitForOncoprint(ONCOPRINT_TIMEOUT); + + var res = checkOncoprintElement('.oncoprintContainer'); + assertScreenShotMatch(res); + }); }); describe("track group headers", function() { beforeEach(function() { - goToUrlAndSetLocalStorage(`${CBIOPORTAL_URL}/results/oncoprint?Z_SCORE_THRESHOLD=2.0&cancer_study_id=coadread_tcga_pub&cancer_study_list=coadread_tcga_pub&case_ids=&case_set_id=coadread_tcga_pub_nonhypermut&gene_list=KRAS%20NRAS%20BRAF&gene_set_choice=user-defined-list&genetic_profile_ids_PROFILE_COPY_NUMBER_ALTERATION=coadread_tcga_pub_gistic&genetic_profile_ids_PROFILE_MUTATION_EXTENDED=coadread_tcga_pub_mutations&heatmap_track_groups=coadread_tcga_pub_rna_seq_mrna_median_Zscores%2CKRAS%2CNRAS%2CBRAF%3Bcoadread_tcga_pub_methylation_hm27%2CKRAS%2CNRAS%2CBRAF&show_samples=false`); + goToUrlAndSetLocalStorage(`${CBIOPORTAL_URL}/results/oncoprint?Z_SCORE_THRESHOLD=2.0&cancer_study_id=coadread_tcga_pub&cancer_study_list=coadread_tcga_pub&case_set_id=coadread_tcga_pub_nonhypermut&gene_list=KRAS%20NRAS%20BRAF&gene_set_choice=user-defined-list&genetic_profile_ids_PROFILE_COPY_NUMBER_ALTERATION=coadread_tcga_pub_gistic&genetic_profile_ids_PROFILE_MUTATION_EXTENDED=coadread_tcga_pub_mutations&heatmap_track_groups=coadread_tcga_pub_rna_seq_mrna_median_Zscores%2CKRAS%2CNRAS%2CBRAF%3Bcoadread_tcga_pub_methylation_hm27%2CKRAS%2CNRAS%2CBRAF&show_samples=false`); $('.alert-warning').$('button.close').click(); // close dev mode notification so it doesnt intercept clicks waitForOncoprint(ONCOPRINT_TIMEOUT); @@ -153,21 +179,6 @@ describe("track group headers", function() { }); describe("sorting", function(){ - - function getNthTrackOptionsElements(n) { - // n is one-indexed - - const button_selector = "#oncoprintDiv .oncoprintjs__track_options__toggle_btn_img.nth-"+n; - const dropdown_selector = "#oncoprintDiv .oncoprintjs__track_options__dropdown.nth-"+n; - - return { - button: $(button_selector), - button_selector, - dropdown: $(dropdown_selector), - dropdown_selector - }; - } - it("oncoprint should sort patients correctly in coadread_tcga_pub", function(){ goToUrlAndSetLocalStorage(CBIOPORTAL_URL); diff --git a/end-to-end-test/remote/specs/core/results.spec.js b/end-to-end-test/remote/specs/core/results.spec.js index d55a98892e8..03e96259d0a 100644 --- a/end-to-end-test/remote/specs/core/results.spec.js +++ b/end-to-end-test/remote/specs/core/results.spec.js @@ -20,7 +20,7 @@ describe('Results Page', function() { describe('single study query with four genes', ()=>{ before(()=>{ - var url = `${CBIOPORTAL_URL}/results/cancerTypesSummary?tab_index=tab_visualize&cancer_study_list=coadread_tcga_pub&cancer_study_id=coadread_tcga_pub&genetic_profile_ids_PROFILE_MUTATION_EXTENDED=coadread_tcga_pub_mutations&genetic_profile_ids_PROFILE_COPY_NUMBER_ALTERATION=coadread_tcga_pub_gistic&Z_SCORE_THRESHOLD=2.0&case_set_id=coadread_tcga_pub_nonhypermut&case_ids=&gene_list=BRAF+KRAS+NRAS&gene_set_choice=user-defined-list&Action=Submit`; + var url = `${CBIOPORTAL_URL}/results/cancerTypesSummary?tab_index=tab_visualize&cancer_study_list=coadread_tcga_pub&cancer_study_id=coadread_tcga_pub&genetic_profile_ids_PROFILE_MUTATION_EXTENDED=coadread_tcga_pub_mutations&genetic_profile_ids_PROFILE_COPY_NUMBER_ALTERATION=coadread_tcga_pub_gistic&Z_SCORE_THRESHOLD=2.0&case_set_id=coadread_tcga_pub_nonhypermut&gene_list=BRAF+KRAS+NRAS&gene_set_choice=user-defined-list&Action=Submit`; goToUrlAndSetLocalStorage(url); browser.waitForVisible('[data-test="cancerTypeSummaryChart"]',10000) }); @@ -133,7 +133,7 @@ describe('Results Page', function() { describe('3D structure visualizer', () => { before(() => { - var url = `${CBIOPORTAL_URL}/results/mutations?tab_index=tab_visualize&cancer_study_list=ov_tcga_pub&cancer_study_id=ov_tcga_pub&genetic_profile_ids_PROFILE_MUTATION_EXTENDED=ov_tcga_pub_mutations&Z_SCORE_THRESHOLD=2.0&case_set_id=ov_tcga_pub_3way_complete&case_ids=&gene_list=BRCA1+BRCA2&gene_set_choice=user-defined-list&Action=Submit`; + var url = `${CBIOPORTAL_URL}/results/mutations?tab_index=tab_visualize&cancer_study_list=ov_tcga_pub&cancer_study_id=ov_tcga_pub&genetic_profile_ids_PROFILE_MUTATION_EXTENDED=ov_tcga_pub_mutations&Z_SCORE_THRESHOLD=2.0&case_set_id=ov_tcga_pub_3way_complete&gene_list=BRCA1+BRCA2&gene_set_choice=user-defined-list&Action=Submit`; browser.url(url); browser.waitForExist('[data-test=view3DStructure]', 10000); browser.waitForEnabled('[data-test=view3DStructure]', 10000); @@ -150,7 +150,7 @@ describe('Results Page', function() { describe('Lollipop Plot Tracks', () => { before(() => { - var url = `${CBIOPORTAL_URL}/results/mutations?tab_index=tab_visualize&cancer_study_list=ov_tcga_pub&cancer_study_id=ov_tcga_pub&genetic_profile_ids_PROFILE_MUTATION_EXTENDED=ov_tcga_pub_mutations&Z_SCORE_THRESHOLD=2.0&case_set_id=ov_tcga_pub_3way_complete&case_ids=&gene_list=TP53+PTEN&gene_set_choice=user-defined-list&Action=Submit`; + var url = `${CBIOPORTAL_URL}/results/mutations?tab_index=tab_visualize&cancer_study_list=ov_tcga_pub&cancer_study_id=ov_tcga_pub&genetic_profile_ids_PROFILE_MUTATION_EXTENDED=ov_tcga_pub_mutations&Z_SCORE_THRESHOLD=2.0&case_set_id=ov_tcga_pub_3way_complete&gene_list=TP53+PTEN&gene_set_choice=user-defined-list&Action=Submit`; browser.url(url); browser.waitForExist('[data-test=view3DStructure]', 10000); browser.waitForEnabled('[data-test=view3DStructure]', 10000); diff --git a/end-to-end-test/remote/specs/core/screenshot.spec.js b/end-to-end-test/remote/specs/core/screenshot.spec.js index f03f5c0b7f6..da25ed05595 100644 --- a/end-to-end-test/remote/specs/core/screenshot.spec.js +++ b/end-to-end-test/remote/specs/core/screenshot.spec.js @@ -126,7 +126,7 @@ function runResultsTestSuite(prefix){ describe('result page screenshot tests', function(){ before(function(){ - var url = `${CBIOPORTAL_URL}/index.do?tab_index=tab_visualize&cancer_study_list=coadread_tcga_pub&cancer_study_id=coadread_tcga_pub&genetic_profile_ids_PROFILE_MUTATION_EXTENDED=coadread_tcga_pub_mutations&genetic_profile_ids_PROFILE_COPY_NUMBER_ALTERATION=coadread_tcga_pub_gistic&Z_SCORE_THRESHOLD=2.0&case_set_id=coadread_tcga_pub_nonhypermut&case_ids=&gene_list=KRAS+NRAS+BRAF&gene_set_choice=user-defined-list&Action=Submit&show_samples=false&`; + var url = `${CBIOPORTAL_URL}/index.do?tab_index=tab_visualize&cancer_study_list=coadread_tcga_pub&cancer_study_id=coadread_tcga_pub&genetic_profile_ids_PROFILE_MUTATION_EXTENDED=coadread_tcga_pub_mutations&genetic_profile_ids_PROFILE_COPY_NUMBER_ALTERATION=coadread_tcga_pub_gistic&Z_SCORE_THRESHOLD=2.0&case_set_id=coadread_tcga_pub_nonhypermut&gene_list=KRAS+NRAS+BRAF&gene_set_choice=user-defined-list&Action=Submit&show_samples=false&`; goToUrlAndSetLocalStorage(url); waitForOncoprint(10000); }); @@ -228,7 +228,7 @@ describe('patient view page screenshot test', function(){ describe("enrichments tab screenshot tests", function() { before(function() { - var url = `${CBIOPORTAL_URL}/results/enrichments?tab_index=tab_visualize&cancer_study_list=coadread_tcga_pub&cancer_study_id=coadread_tcga_pub&genetic_profile_ids_PROFILE_MUTATION_EXTENDED=coadread_tcga_pub_mutations&genetic_profile_ids_PROFILE_COPY_NUMBER_ALTERATION=coadread_tcga_pub_gistic&Z_SCORE_THRESHOLD=2.0&case_set_id=coadread_tcga_pub_nonhypermut&case_ids=&gene_list=KRAS+NRAS+BRAF&gene_set_choice=user-defined-list&Action=Submit`; + var url = `${CBIOPORTAL_URL}/results/enrichments?tab_index=tab_visualize&cancer_study_list=coadread_tcga_pub&cancer_study_id=coadread_tcga_pub&genetic_profile_ids_PROFILE_MUTATION_EXTENDED=coadread_tcga_pub_mutations&genetic_profile_ids_PROFILE_COPY_NUMBER_ALTERATION=coadread_tcga_pub_gistic&Z_SCORE_THRESHOLD=2.0&case_set_id=coadread_tcga_pub_nonhypermut&gene_list=KRAS+NRAS+BRAF&gene_set_choice=user-defined-list&Action=Submit`; goToUrlAndSetLocalStorage(url); }); it('enrichments tab coadread_tcga_pub mRNA profile', function(){ @@ -280,7 +280,7 @@ describe('result page tabs, loading from session id', function(){ describe('error messaging for 400 error', function(){ before(function(){ - var url = `${CBIOPORTAL_URL}/results/oncoprint?Z_SCORE_THRESHOLD=2.0&cancer_study_id=coadread_tcga_pub&cancer_study_list=coadread_tcga_pub&case_ids=&case_set_id=coadread_tcga_pubb_nonhypermut&gene_list=KRAS%20NRAS%20BRAF&gene_set_choice=user-defined-list&genetic_profile_ids_PROFILE_COPY_NUMBER_ALTERATION=coadread_tcga_pub_gistic&genetic_profile_ids_PROFILE_MUTATION_EXTENDED=coadread_tcga_pub_mutations`; + var url = `${CBIOPORTAL_URL}/results/oncoprint?Z_SCORE_THRESHOLD=2.0&cancer_study_id=coadread_tcga_pub&cancer_study_list=coadread_tcga_pub&case_set_id=coadread_tcga_pubb_nonhypermut&gene_list=KRAS%20NRAS%20BRAF&gene_set_choice=user-defined-list&genetic_profile_ids_PROFILE_COPY_NUMBER_ALTERATION=coadread_tcga_pub_gistic&genetic_profile_ids_PROFILE_MUTATION_EXTENDED=coadread_tcga_pub_mutations`; goToUrlAndSetLocalStorage(url); }); diff --git a/src/shared/components/oncoprint/DeltaUtils.ts b/src/shared/components/oncoprint/DeltaUtils.ts index 909e7a2efec..6e45a11b30b 100644 --- a/src/shared/components/oncoprint/DeltaUtils.ts +++ b/src/shared/components/oncoprint/DeltaUtils.ts @@ -653,7 +653,9 @@ function tryRemoveTrack( // removeCallback to forget its track ID const trackId = trackSpecKeyToTrackId[prevSpec.key]; if (typeof trackId !== "undefined") { - oncoprint.removeTrack(trackId); + if (oncoprint.getTracks().includes(trackId)) { + oncoprint.removeTrack(trackId); + } delete trackSpecKeyToTrackId[prevSpec.key]; } return true; @@ -864,8 +866,10 @@ function transitionClinicalTrack( label: nextSpec.label, description: ((nextSpec.label || "").trim() === (nextSpec.description || "").trim()) ? undefined : nextSpec.description, removable: true, - removeCallback: ()=>{ + removeCallback: () => { delete getTrackSpecKeyToTrackId()[nextSpec.key]; + }, + onClickRemoveInTrackMenu: ()=>{ nextProps.onDeleteClinicalTrack && nextProps.onDeleteClinicalTrack(nextSpec.key); }, sort_direction_changeable: true, @@ -1010,12 +1014,15 @@ export function transitionHeatmapTrack( track_label_font_weight: nextSpec.labelFontWeight, track_label_left_padding: nextSpec.labelLeftPadding, target_group: nextSpec.trackGroupIndex, - removable: !!nextSpec.onRemove, + removable: !!nextSpec.onRemove || !!nextSpec.onClickRemoveInTrackMenu, movable: nextSpec.movable, na_legend_label: nextSpec.naLegendLabel, removeCallback: ()=>{ delete getTrackSpecKeyToTrackId()[nextSpec.key]; - if (nextSpec.onRemove) nextSpec.onRemove(); + nextSpec.onRemove && nextSpec.onRemove(); + }, + onClickRemoveInTrackMenu:()=>{ + nextSpec.onClickRemoveInTrackMenu && nextSpec.onClickRemoveInTrackMenu(); }, sort_direction_changeable: ifNotDefined(nextSpec.sortDirectionChangeable, true), sortCmpFn: heatmapTrackSortComparator, diff --git a/src/shared/components/oncoprint/Oncoprint.tsx b/src/shared/components/oncoprint/Oncoprint.tsx index 801043fe40e..ed5f7fd8477 100644 --- a/src/shared/components/oncoprint/Oncoprint.tsx +++ b/src/shared/components/oncoprint/Oncoprint.tsx @@ -120,7 +120,6 @@ export interface IBaseHeatmapTrackSpec { export interface IHeatmapTrackSpec extends IBaseHeatmapTrackSpec { data: IBaseHeatmapTrackDatum[]; // can be IGeneHeatmapTrackDatum or ITreatmentHeatmapTrackDatum naLegendLabel?:string; - onRemove?: () => void; info?: string; labelColor?: string; labelCircleColor?: string; @@ -131,6 +130,8 @@ export interface IHeatmapTrackSpec extends IBaseHeatmapTrackSpec { movable?:boolean; sortDirectionChangeable?:boolean; // never updated trackLinkUrl?: string | undefined; + onRemove?:()=>void; + onClickRemoveInTrackMenu?: ()=>void; molecularProfileName?: string; pivotThreshold?: number; sortOrder?: string; diff --git a/src/shared/components/oncoprint/OncoprintUtils.ts b/src/shared/components/oncoprint/OncoprintUtils.ts index 63466bcb26c..fb3d0aeacc4 100644 --- a/src/shared/components/oncoprint/OncoprintUtils.ts +++ b/src/shared/components/oncoprint/OncoprintUtils.ts @@ -714,7 +714,7 @@ export function makeHeatmapTracksMobxPromise(oncoprint:ResultsViewOncoprint, sam data ), trackGroupIndex: molecularProfileIdToHeatmapTracks[molecularProfileId].trackGroupIndex, - onRemove:action(()=>{ + onClickRemoveInTrackMenu:action(()=>{ const trackGroup = oncoprint.molecularProfileIdToHeatmapTracks[molecularProfileId]; if (trackGroup) { const newEntities = _.keys(trackGroup.entities).filter((entity)=>entity!==gene); @@ -799,8 +799,7 @@ export function makeTreatmentProfileHeatmapTracksMobxPromise(oncoprint:ResultsVi sortOrder: sortOrder, trackLinkUrl: treatmentLinkMap[treatmentId], trackGroupIndex: molecularProfileIdToHeatmapTracks[molecularProfileId]!.trackGroupIndex, - onRemove:action(()=>{ - + onClickRemoveInTrackMenu:action(()=>{ const trackGroup = oncoprint.molecularProfileIdToHeatmapTracks[molecularProfileId]!; if (trackGroup){ const newEntities = _.keys(trackGroup.entities).filter((entity)=>entity!==treatmentId);