Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResultsView Comparison: Switching Generic Assay profiles does not update data #10520

Closed
MatthijsPon opened this issue Jan 8, 2024 · 2 comments · Fixed by cBioPortal/cbioportal-frontend#4922

Comments

@MatthijsPon
Copy link
Contributor

MatthijsPon commented Jan 8, 2024

If you have multiple generic assays loaded under the same 'generic_assay_type', they aggregate into a single tab. However, when selecting between the different datasets in the ResultsView comparison view, the data is not updated. It seems like there is no request being made to the backend when switching.

Reproduce:

  1. Select study ccle_broad_2019
  2. Query for TP53
  3. Click Comparison tab
  4. Click Treatment Response sub-tab (direct link)
  5. Switch between the different datasets using the dropdown

Dataset 1:
image

Dataset 2:
image

@MatthijsPon MatthijsPon changed the title Query-By-Gene -> Comparison: Switching Generic Assay profiles does not update data ResultsView Comparison: Switching Generic Assay profiles does not update data Jan 15, 2024
@baeywen
Copy link

baeywen commented Jan 26, 2024

till 1/26/2024, the issue has not been fixed in https://www.cbioportal.org/. here is example to reproduce the bug.
under https://www.cbioportal.org/study/summary?id=ccle_broad_2019. compare based on any grouping, in the result page, click 'Treatment Response', then switch different "Data set", the result below won't update when different "data set" selected.
image

@TJMKuijpers
Copy link

The issue seems to be introduced in this PR .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants