Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow log scale for certain clinical attributes in plots tab #4456

Closed
adamabeshouse opened this issue Jul 16, 2018 · 8 comments
Closed

allow log scale for certain clinical attributes in plots tab #4456

adamabeshouse opened this issue Jul 16, 2018 · 8 comments
Assignees
Labels

Comments

@adamabeshouse
Copy link
Contributor

No description provided.

@adamabeshouse
Copy link
Contributor Author

@inodb @jjgao how do we decide which clinical attributes can have log scale? is it just total mutations?

@jjgao
Copy link
Member

jjgao commented Jul 16, 2018

@adamabeshouse maybe we can add a log option (toggle on/off, by default off) for any number attributes.

You can also do that for negative numbers:

image

https://community.tableau.com/thread/105453

@zhx828
Copy link
Member

zhx828 commented Jul 16, 2018

@onursumer study view bar chart may need this too, not critical yet.

@jjgao
Copy link
Member

jjgao commented Jul 16, 2018

@zhx828 @onursumer it was an example to show how to do log transformation for negative data, but yeah it can be useful in study view page.

@adamabeshouse
Copy link
Contributor Author

@jjgao i think that strategy would only work for data greater in absolute value than 1, as in the link. not sure how it would work for values whose log is negative

@jjgao
Copy link
Member

jjgao commented Jul 16, 2018

@adamabeshouse you are right... I couldn't think of a general solution. Let's do some more research.

@adamabeshouse
Copy link
Contributor Author

for now we could hardcode it in for total mutations?

@jjgao
Copy link
Member

jjgao commented Jul 17, 2018

@adamabeshouse ok. Maybe make it an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants