Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

study view - bugs when adding/removing charts while filter is applied #5562

Closed
tmazor opened this issue Jan 7, 2019 · 16 comments
Closed

study view - bugs when adding/removing charts while filter is applied #5562

tmazor opened this issue Jan 7, 2019 · 16 comments

Comments

@tmazor
Copy link
Contributor

tmazor commented Jan 7, 2019

Go to MSK Impact study view: http://www.cbioportal.org/study?id=msk_impact_2017
Select Breast Cancer
Add "Metastatic Site" chart
--> problem 1: it adds as a pie chart, but should add as a table since there are >20 values
Click the "x" on the Metastatic Site pie chart to remove it.
Click "Clear All Filters"
--> problem 2: when the page reloads without the filter, the Metastatic Site chart appears

@jjgao
Copy link
Member

jjgao commented Jan 7, 2019

@zhx828 I think both issues were reported. Could you link them?

@jjgao
Copy link
Member

jjgao commented Jan 7, 2019

... and fix them :)

@zhx828
Copy link
Member

zhx828 commented Jan 7, 2019

Hm I can't reproduce the issue though. @jjgao can you?

@zhx828
Copy link
Member

zhx828 commented Jan 7, 2019

The first issue was solved a while ago.

@zhx828 zhx828 unassigned jjgao and zhx828 Jan 7, 2019
@jjgao
Copy link
Member

jjgao commented Jan 7, 2019

both seem fixed. I was able to reproduce a few hours ago... closing

@jjgao jjgao closed this as completed Jan 7, 2019
@tmazor
Copy link
Contributor Author

tmazor commented Jan 8, 2019

This is still happening for me - I've tested chrome & safari and both issues happen in both browsers

@tmazor tmazor reopened this Jan 8, 2019
@jjgao
Copy link
Member

jjgao commented Jan 8, 2019

hmm.. strange. I tried again and had the same issues. But after refreshing, the issues were gone.

@tmazor
Copy link
Contributor Author

tmazor commented Jan 8, 2019

weird... even with a hard refresh, it happens consistently for me.

@jjgao
Copy link
Member

jjgao commented Jan 8, 2019

hmm.. I am wondering if we have some inconsistency between the two servers. @inodb is deploying the new version. Let's try after that.

@tmazor
Copy link
Contributor Author

tmazor commented Jan 8, 2019

I just tried and I still see both issues

@jjgao
Copy link
Member

jjgao commented Jan 8, 2019

@tmazor could you try in another browser or in incognito? Trying to figure out if it's caching issue.

@tmazor
Copy link
Contributor Author

tmazor commented Jan 8, 2019

I just tried incognito mode in chrome & safari and it happens in both

@jjgao
Copy link
Member

jjgao commented Jan 8, 2019

This is very strange. @zhx828 any thoughts?

@zhx828
Copy link
Member

zhx828 commented Jan 9, 2019

@jjgao I was thinking the same thing. The latest code was not deployed to both servers. But at the time Tali tested yesterday 3pm. We have redeployed all wars to both servers. And the second issue on this ticket, it looks like a side effect of the first issue. But the thing is I tried both Chrome and Safari several times. I can't reproduce the issue.

@zhx828
Copy link
Member

zhx828 commented Jan 9, 2019

I now can reproduce the bug. Will fix it soon.

@zhx828
Copy link
Member

zhx828 commented Jan 10, 2019

@tmazor @jjgao this issue is now solved and deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants