treatment_list url parameter lost when going from Oncoprint to Plots Tab

[pvannierop]

Current behavior

Selecting a treatment response profile in oncoprint sets the treatment_list url parameter. Navigation to Plots Tab updates the url to be handled by session service.

https://www.cbioportal.org/results/plots?session_id=5da82b12e4b0656ac4cf4226

Because the the treatment_list parameter is not available for Plots Tab this components gives an error that notify the user has not selected treatments in oncoprint even though the treatments were added in this component (see movie below).

Desired behavior

By selecting a treatment response profile in oncoprint the treatment_list url parameter is set. When navigating to Plots Tab the treatment_list parameter persisted and is interpreted by the Plots Tab component and is used to populate the axis menu's for treatment entries.

Analysis

The update to handle the URL by session service seems incompatible with the way the treatments axis menu is populated.

[adamabeshouse]

@alisman lets address this with URLWrapper work

[alisman]

@adamabeshouse i agree. i wonder if it only happens when URL length is near threshold for conversion to session.

[alisman]

@pvannierop this is now fixed in the following PR. You can see here:

https://cbioportal-f-urlwrapper-uk1qmc.herokuapp.com/results/oncoprint?session_id=5da82b12e4b0656ac4cf4226

In addition all oncoprint sorting options are now read from/written to URL.

PR is not quite ready for review. But we're close. I will assign it to so you can have a look.

[Sjoerd-van-Hagen]

@alisman any updates on this?

[alisman]

@Sjoerd-van-Hagen there are some complications that have come up with my fix. i will consider merging @pvannierop fix temporarily

[Sjoerd-van-Hagen]

@alisman thanks for the update.

[pvannierop]

This issue is fixed with PR cBioPortal/cbioportal-frontend#2726.