-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nfosi jhu dataset #2035
base: master
Are you sure you want to change the base?
Update nfosi jhu dataset #2035
Conversation
@ritikakundra Help with this? |
@anngvu is this for private access? |
@ritikakundra I am chiming in here on behalf of @anngvu, This is for the public portal. This is the original study which needs to be updated. We are hoping to highlight this update/new submission in a conference in June, 2024. Would it be possible to add these updates before mid June? |
Thank you for the study update and PR! The data looks good but I have a couple of fixes before we can merge:
I added some attributes required by cBioPortal to the clinical files such as ONCOTREE_CODE, CANCER_TYPE, CANCER_TYPE_DETAILED, & TMB_NONSYNONYMOUS. Looking forward to update the study! |
@Rima-Waleed Thanks for the review.
This submission updates the previous cohort by adding additional batches of samples. The new preprint that describes the full cohort is here: https://www.biorxiv.org/content/10.1101/2024.01.23.576977v1. Please add this preprint along with the original publication for reference. I am tagging @anngvu to address the points 2,3, and 4. |
@Rima-Waleed Thanks for the notes, we'll update these. I think the SOMATIC_STATUS is new (at least it wasn't pointed out last time). |
Hmm, I am unable to update the last thing because I get this: It sounds as if cBioPortal account rather than ours needs to purchase bandwidth for LFS?
UPDATE: Actually, it looks like we are the ones who need to update storage according to this: |
Hi @anngvu, |
Add somatic status
@Rima-Waleed No worries, I confirmed side of the bandwidth issue a couple of days ago. Maybe we can find a way to donate bandwidth through GitHub sponsorship? Just an idea -- I'll talk to Ino and Ritika. Anyway, made suggested updates with somatic status (and we're only going to keep TPM). Thanks! |
@Rima-Waleed All files are updated. |
Thank you @anngvu! Doing a final review of the study and sending you the study link soon. |
@Rima-Waleed @ritikakundra Just wanted to follow up here to see if it would be possible to update the study on the public portal by today or tomorrow. We are hoping to showcase the study and cBioPortal functionalities in an upcoming international conference (on Friday) if possible. :) |
@jaybee84 We are just wrapping up it up. We will have the link ready by tomorrow morning. |
Super! Thanks to the whole cBioPortal team and specially to @Rima-Waleed and @ritikakundra for pushing this through ! Really appreciate the help. |
Hi @jaybee84, thank you for your patience and collaboration! We have the public link ready and you can access the study using this link: https://www.cbioportal.org/study/summary?id=nst_jhusm_2020 I had to make some edits to make sure the study complies with cBioPortal formats, so please let me know if you have any questions. Also, this is an easy fix but I just wanted to make sure which paper you want linked to the study: just the preprint, or the original study, or both? |
@Rima-Waleed Thanks for making this ready so quickly. Couple of thoughts:
Is it possible to update the original study link: https://www.cbioportal.org/study/summary?id=nst_nfosi_ntap instead of making a new one? This is an ongoing project with additional samples from the same biobank. Also, can we add the description that has been included in the Readme of this PR?
We should include both. |
@jaybee84 thanks for the feedback. Of course! This link was a test link just to get your approval before updating the original study link. I have added the original description along with the preprint and citation in the description. The study should be imported to public portal after midnight and you'll be able to see the updated study here: https://www.cbioportal.org/study/summary?id=nst_nfosi_ntap |
Thanks @Rima-Waleed. The updated study looks great. Thanks again for all the help! |
Oh! actually one more request: |
What?
Fix #2034
Cancer studies updated in this pull request:
checks
For all pull requests:
For a new study (in addition to above):