Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.1 behavior change #168

Closed
NathanBaulch opened this issue Aug 9, 2024 · 2 comments
Closed

v2.1 behavior change #168

NathanBaulch opened this issue Aug 9, 2024 · 2 comments

Comments

@NathanBaulch
Copy link

Thanks for the v2.1.1 release @caarlos0, that solved the Windows issue!

However there's still a behavior change in this version that's worth mentioning. I have a monorepo where all components are versioned in unison. Starting in v2.1 I can no longer get the current tagged version in scripts and Makefiles within sub-directories. Unless I explicitly specify the pattern and prefix arguments, #161 means svu will always assume I'm in a sub-package now.

I'm not sure what the best solution for this is, but IMO the new behavior feels overly opinionated/unexpected.

@mcinj
Copy link

mcinj commented Aug 24, 2024

I'm not sure what the best solution for this is, but IMO the new behavior feels overly opinionated/unexpected.

@NathanBaulch, I agree. This feels like a change that should be rolled back. While it is a new feature, it broke existing functionality and I don't think both can exist without some extra flag/configuration to say "be more opinionated".

@caarlos0
Copy link
Owner

reverted the changes that caused this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants