Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api is not matching the one from bson - getTimestamp #43

Closed
dawidreedsy opened this issue Oct 28, 2021 · 4 comments · Fixed by #47
Closed

Api is not matching the one from bson - getTimestamp #43

dawidreedsy opened this issue Oct 28, 2021 · 4 comments · Fixed by #47

Comments

@dawidreedsy
Copy link

getTimestamp should return the Date at the moment is returning the number
@niftylettuce
Copy link
Collaborator

Can you submit a PR to fix this?

@MrEmanuel
Copy link
Contributor

It's actually returning Date as of now, but is typed to return number. I'll make a quick PR to fix it. :)

@rparet rparet mentioned this issue Mar 12, 2022
Merged
@niftylettuce
Copy link
Collaborator

The PR #46 broke all tests. I am going to revert it in the interim.

I also noticed we need to merge this 418sec#2.

@niftylettuce niftylettuce reopened this Mar 12, 2022
@niftylettuce
Copy link
Collaborator

This should be fixed now in v2.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed type on getTimestamp()
3 participants
@niftylettuce @MrEmanuel @dawidreedsy