Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsValid returns true for invalid binary data #45

Open
erezarnon opened this issue Dec 13, 2021 · 2 comments
Open

IsValid returns true for invalid binary data #45

erezarnon opened this issue Dec 13, 2021 · 2 comments

Comments

@erezarnon
Copy link 

> ObjectId.isValid("�½��ļ���.zip")
true
> ObjectId("�½��ļ���.zip")
ObjectID(undefinedbdundefinedundefinedundefinedundefinedundefinedundefined2e7a6970)
@niftylettuce
Copy link
Collaborator

PR welcome to fix this!

@niftylettuce niftylettuce mentioned this issue Jan 20, 2022
Merged
@niftylettuce
Copy link
Collaborator

The PR #46 broke all tests. I am going to revert it in the interim.

I also noticed we need to merge this 418sec#2.

@niftylettuce niftylettuce reopened this Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niftylettuce @erezarnon