add error handling for StringSlice

caddyserver · Sep 6, 2023 · 6a43c18 · 6a43c18
1 parent 3fe3cc8
commit 6a43c18
Showing 1 changed file with 16 additions and 4 deletions.
diff --git a/cmd/commandfuncs.go b/cmd/commandfuncs.go
@@ -156,16 +156,23 @@ func cmdStart(fl Flags) (int, error) {
 
 func cmdRun(fl Flags) (int, error) {
 	caddy.TrapSignals()
+	var err error
 
 	runCmdConfigFlag := fl.String("config")
 	runCmdConfigAdapterFlag := fl.String("adapter")
 	runCmdResumeFlag := fl.Bool("resume")
-	runCmdLoadEnvfileFlag, _ := fl.GetStringSlice("envfile")
 	runCmdPrintEnvFlag := fl.Bool("environ")
 	runCmdWatchFlag := fl.Bool("watch")
 	runCmdPidfileFlag := fl.String("pidfile")
 	runCmdPingbackFlag := fl.String("pingback")
 
+	var runCmdLoadEnvfileFlag []string
+	runCmdLoadEnvfileFlag, err = fl.GetStringSlice("envfile")
+	if err != nil {
+		return caddy.ExitCodeFailedStartup,
+			fmt.Errorf("reading envfile flag: %v", err)
+	}
+
 	// load all additional envs as soon as possible
 	for _, envFile := range runCmdLoadEnvfileFlag {
 		if err := loadEnvFromFile(envFile); err != nil {
@@ -181,7 +188,6 @@ func cmdRun(fl Flags) (int, error) {
 
 	// load the config, depending on flags
 	var config []byte
-	var err error
 	if runCmdResumeFlag {
 		config, err = os.ReadFile(caddy.ConfigAutosavePath)
 		if os.IsNotExist(err) {
@@ -495,9 +501,16 @@ func cmdAdaptConfig(fl Flags) (int, error) {
 }
 
 func cmdValidateConfig(fl Flags) (int, error) {
+	var err error
 	validateCmdConfigFlag := fl.String("config")
 	validateCmdAdapterFlag := fl.String("adapter")
-	runCmdLoadEnvfileFlag, _ := fl.GetStringSlice("envfile")
+
+	var runCmdLoadEnvfileFlag []string
+	runCmdLoadEnvfileFlag, err = fl.GetStringSlice("envfile")
+	if err != nil {
+		return caddy.ExitCodeFailedStartup,
+			fmt.Errorf("reading envfile flag: %v", err)
+	}
 
 	// load all additional envs as soon as possible
 	for _, envFile := range runCmdLoadEnvfileFlag {
@@ -508,7 +521,6 @@ func cmdValidateConfig(fl Flags) (int, error) {
 	}
 
 	// use default config and ensure a config file is specified
-	var err error
 	validateCmdConfigFlag, err = configFileWithRespectToDefault(caddy.Log(), validateCmdConfigFlag)
 	if err != nil {
 		return caddy.ExitCodeFailedStartup, err