Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace strings.Index usages with strings.Cut where possible #4928

Closed
francislavoie opened this issue Aug 2, 2022 · 3 comments · Fixed by #4930
Closed

Replace strings.Index usages with strings.Cut where possible #4928

francislavoie opened this issue Aug 2, 2022 · 3 comments · Fixed by #4930
Labels
good first issue 🐤 Good for newcomers optimization 📉 Performance or cost improvements
Milestone
2.x

Comments

@francislavoie
Copy link
Member

We can now use the new strings.Cut function which should simplify some code. See https://tip.golang.org/doc/go1.18#strings
@francislavoie francislavoie added good first issue 🐤 Good for newcomers optimization 📉 Performance or cost improvements labels Aug 2, 2022
@francislavoie francislavoie added this to the 2.x milestone Aug 2, 2022
@francislavoie francislavoie mentioned this issue Aug 2, 2022
Merged
@Chi3f1991

This comment was marked as spam.

Sign in to view
@Chi3f1991

This comment was marked as spam.

Sign in to view
@WilczynskiT WilczynskiT mentioned this issue Aug 4, 2022
Merged
@chir4gm
Copy link
Contributor

chir4gm commented Aug 4, 2022

Hi, I tried my hand at this Issue, and have requested a PR.
I hope the simple changes suffice.

ps. Thank you for the efforts you have put into making this awesome web server!

@chir4gm chir4gm mentioned this issue Aug 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue 🐤 Good for newcomers optimization 📉 Performance or cost improvements
Projects
None yet
Milestone
2.x
Development

Successfully merging a pull request may close this issue.

Replace strings.Index usages with strings.Cut WilczynskiT/caddy
3 participants
@francislavoie @chir4gm @Chi3f1991