Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.7.3 fails go install on mac on go1.21.0 #5750

Closed
gedw99 opened this issue Aug 15, 2023 · 2 comments
Closed

v2.7.3 fails go install on mac on go1.21.0 #5750

gedw99 opened this issue Aug 15, 2023 · 2 comments
Labels
duplicate 🖇️ This issue or pull request already exists

Comments

@gedw99
Copy link

gedw99 commented Aug 15, 2023

using https://github.com/caddyserver/caddy/releases/tag/v2.7.3

I guess i must still with go 1.20 for now...

go version go1.21.0 darwin/amd64

go install -ldflags="-X main.version=v2.7.3" github.com/caddyserver/caddy/v2/cmd/[email protected]
# github.com/quic-go/quic-go/internal/handshake
/Users/apple/go/pkg/mod/github.com/quic-go/[email protected]/internal/handshake/crypto_setup.go:362:37: cannot use h.allow0RTT (variable of type bool) as tls.QUICSessionTicketOptions value in argument to h.conn.SendSessionTicket

on go1.20 its a happy chappy.

go version go1.20 darwin/amd64
go install -ldflags="-X main.version=v2.7.3" github.com/caddyserver/caddy/v2/cmd/[email protected]

on go version devel go1.22-94d36fbc Tue Aug 15 13:58:27 2023 +0000 darwin/amd64

gotip install -ldflags="-X main.version=v2.7.3" github.com/caddyserver/caddy/v2/cmd/[email protected]
# github.com/quic-go/quic-go/internal/handshake
/Users/apple/go/pkg/mod/github.com/quic-go/[email protected]/internal/handshake/crypto_setup.go:362:37: cannot use h.allow0RTT (variable of type bool) as tls.QUICSessionTicketOptions value in argument to h.conn.SendSessionTicket
@gedw99 gedw99 changed the title v2.7.3 fails go install on mac on go1.21.1 v2.7.3 fails go install on mac on go1.21.0 Aug 15, 2023
@francislavoie
Copy link
Member

francislavoie commented Aug 15, 2023

Yep, fixed on master branch with #5719. We'll release v2.7.4 this week with Go 1.21 support. Feel free to build from master if you need it now.

@francislavoie francislavoie closed this as not planned Won't fix, can't repro, duplicate, stale Aug 15, 2023
@francislavoie francislavoie added the duplicate 🖇️ This issue or pull request already exists label Aug 15, 2023
@gedw99
Copy link
Author

gedw99 commented Aug 15, 2023

Thanks @francislavoie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate 🖇️ This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants