Placeholder shorthands are not replaced in named routes

[pkoenig10]

The following Caddyfile:

&(named) {
    vars Test {header.test}
}

example.com {
    invoke named
    vars Test {header.test}
}

Produces the following config:

{
    "apps": {
        "http": {
            "servers": {
                "srv0": {
                    "listen": [
                        ":443"
                    ],
                    "routes": [
                        {
                            "match": [
                                {
                                    "host": [
                                        "example.com"
                                    ]
                                }
                            ],
                            "handle": [
                                {
                                    "handler": "subroute",
                                    "routes": [
                                        {
                                            "handle": [
                                                {
                                                    "Test": "{http.request.header.test}",
                                                    "handler": "vars"
                                                },
                                                {
                                                    "handler": "invoke",
                                                    "name": "named"
                                                }
                                            ]
                                        }
                                    ]
                                }
                            ],
                            "terminal": true
                        }
                    ],
                    "named_routes": {
                        "named": {
                            "handle": [
                                {
                                    "Test": "{header.test}",
                                    "handler": "vars"
                                }
                            ]
                        }
                    }
                }
            }
        }
    }
}

I see that named routes are still an experimental feature, so I'm not sure if this behavior is intentional or a known limitation.

If this is not a bug, I think it would be helpful to call out in the documentation. It took me while to debug why my placeholders were not working as I would have expected.

[francislavoie]

That does seem like a bug. Interesting.

[hainenber]

I discovered that the named_routes blocks don't go through substitution of placeholder shorthands, as with the origin server blocks (source). The fix is to have the named_routes undergo same treatment.

I've made a draft PR here. Please have a look. Thanks!

[mholt]

Cool, thank you for taking initiative on this while we've been busy @hainenber! We appreciate your contribution.